-
-
Notifications
You must be signed in to change notification settings - Fork 33.9k
socket documentation fix - rename triple to 3-tuple #24722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
socket documentation fix - rename triple to 3-tuple #24722
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
|
This PR is stale because it has been open for 30 days with no activity. |
|
Closing and re-opening to trigger CI. |
|
Cant build, cant review: Warning, treated as error: |
In mathematics, a triple is a common name for a tuple of three elements. I'm +0 on this change. A |
|
Closing & re-opening to re-trigger CLA. |
|
I think that one could deduce that triple = 3-tuple just by context, but since |
EmberCraze
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
GH-109073 is a backport of this pull request to the 3.12 branch. |
(cherry picked from commit 6b15ff5) Co-authored-by: Ori Hoch <ori@uumpa.com> Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
(cherry picked from commit 6b15ff5) Co-authored-by: Ori Hoch <ori@uumpa.com> Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
|
GH-109074 is a backport of this pull request to the 3.11 branch. |
was a bit confusing to me looking at this doc, wasn't sure what a triple meant, also, I believe it has other meanings in different contexts..
Searching the docs I see a lot of usages of 3-tuple, so I assume it's more standard.