bpo-4928: Document NamedTemporaryFile non-deletion after SIGKILL#26198
Conversation
freddrake
left a comment
freddrake
left a comment
There was a problem hiding this comment.
reStructuredText shortcomings can be annoying; sorry!
Small change is needed.
Doc/library/tempfile.rst
Outdated
| be used in a :keyword:`with` statement, just like a normal file. | ||
|
|
||
| On POSIX (only), a process that is terminated abruptly with SIGKILL | ||
| cannot automatically delete :func:`NamedTemporaryFile`s it created. |
There was a problem hiding this comment.
As noted by the GitHub action, this reStructuredText is broken.
Suggested alternate:
On POSIX (only), a process that is terminated abruptly with SIGKILL
cannot automatically delete a :func:`NamedTemporaryFile` it created.
There was a problem hiding this comment.
oop, pushed a different resolution before seeing your suggestion...
Thanks & sorry, would have caught this but make html is failing for me and I foolishly thought I could get by without it...
There was a problem hiding this comment.
No worries. While I like reStructuredText better than some widely used alternatives... it has warts.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
@freddrake: Please replace |
4 participants
Consensus on https://bugs.python.org/issue4928 seems to be that documenting the behavior is all we can really do. Submitting this as suggested wording.
https://bugs.python.org/issue4928