Skip to content

bpo-43950: support some multi-line expressions for PEP 657 #27339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miss-islington merged 2 commits into from
Jul 25, 2021
Merged

bpo-43950: support some multi-line expressions for PEP 657 #27339

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d8136f
bpo-43950: support multi-line expressions if the intruction covers th…
isidentical Jul 24, 2021
b6a2bd4
add more test cases
isidentical Jul 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add more test cases
  • Loading branch information
@isidentical
isidentical committed Jul 25, 2021
commit b6a2bd4e746ddda2e7657a95eb0df511f2e9067c
23 changes: 23 additions & 0 deletions Lib/test/test_traceback.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,6 +434,29 @@ def f_with_multiline():
result_lines = self.get_exception(f_with_multiline)
self.assertEqual(result_lines, expected_f.splitlines())

def test_caret_multiline_expression_bin_op(self):
# Make sure no carets are printed for expressions spanning multiple
# lines.
def f_with_multiline():
return (
1 /
0 +
2
)

lineno_f = f_with_multiline.__code__.co_firstlineno
expected_f = (
'Traceback (most recent call last):\n'
f' File "{__file__}", line {self.callable_line}, in get_exception\n'
' callable()\n'
' ^^^^^^^^^^\n'
f' File "{__file__}", line {lineno_f+2}, in f_with_multiline\n'
' 1 /\n'
' ^^^'
)
result_lines = self.get_exception(f_with_multiline)
self.assertEqual(result_lines, expected_f.splitlines())

def test_caret_for_binary_operators(self):
def f_with_binary_operator():
divisor = 20
Expand Down