Skip to content

Add .DS_store on ignore#27711

Merged
ambv merged 2 commits into
python:mainfrom
180909:add-DS_store-on-ignore
Aug 11, 2021
Merged

Add .DS_store on ignore#27711
ambv merged 2 commits into
python:mainfrom
180909:add-DS_store-on-ignore

Conversation

@180909

@180909 180909 commented Aug 10, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@the-knights-who-say-ni

the-knights-who-say-ni commented Aug 10, 2021

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@180909

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

ambv
ambv reviewed Aug 10, 2021
View reviewed changes
Comment thread .gitignore Outdated
@180909 @ambv
Update .gitignore
295dd60 
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@ambv ambv merged commit 1841c70 into python:main Aug 11, 2021
@miss-islington

miss-islington commented Aug 11, 2021

Copy link
Copy Markdown
Contributor

Thanks @180909 for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Aug 11, 2021
@bedevere-bot

bedevere-bot commented Aug 11, 2021

Copy link
Copy Markdown

GH-27723 is a backport of this pull request to the 3.10 branch.

@bedevere-bot

bedevere-bot commented Aug 11, 2021

Copy link
Copy Markdown

GH-27724 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 11, 2021
@180909 @miss-islington
Add .DS_Store on ignore (pythonGH-27711)
43c276c 
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
(cherry picked from commit 1841c70)

Co-authored-by: 180909 <wjh180909@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 11, 2021
@180909 @miss-islington
Add .DS_Store on ignore (pythonGH-27711)
92c3da0 
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
(cherry picked from commit 1841c70)

Co-authored-by: 180909 <wjh180909@gmail.com>
ambv pushed a commit that referenced this pull request Aug 11, 2021
@miss-islington @180909
Add .DS_Store on ignore (GH-27711) (GH-27724)
8c93a63 
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
(cherry picked from commit 1841c70)

Co-authored-by: 180909 <wjh180909@gmail.com>
@180909 180909 deleted the add-DS_store-on-ignore branch August 11, 2021 13:01
@180909 180909 restored the add-DS_store-on-ignore branch August 11, 2021 13:01
@180909 180909 deleted the add-DS_store-on-ignore branch August 11, 2021 13:01
@180909 180909 restored the add-DS_store-on-ignore branch August 11, 2021 13:01
ambv pushed a commit that referenced this pull request Aug 11, 2021
@miss-islington @180909
Add .DS_Store on ignore (GH-27711) (GH-27723)
e8a43ef 
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
(cherry picked from commit 1841c70)

Co-authored-by: 180909 <wjh180909@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambv ambv ambv left review comments

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@180909 @the-knights-who-say-ni @miss-islington @bedevere-bot @ambv