Skip to content

bpo-45653: fix test_embed on windows #29814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gvanrossum merged 1 commit into from
Nov 29, 2021
Merged

bpo-45653: fix test_embed on windows #29814

gvanrossum merged 1 commit into from
Nov 29, 2021

Conversation

@kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Nov 27, 2021 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Nov 27, 2021
@kumaraditya303
Copy link
Contributor Author

kumaraditya303 commented Nov 27, 2021

I know how to run tests but when I run test_embed on windows it skips it saying that _testembed.exe doesn't exists, even though it exists.

@gvanrossum this fixes the issue of test_embed getting skipped when trying to run it.

@kumaraditya303 kumaraditya303 marked this pull request as ready for review November 27, 2021 09:51
@gvanrossum gvanrossum self-requested a review November 29, 2021 18:31
gvanrossum
gvanrossum approved these changes Nov 29, 2021
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks fine.

@gvanrossum gvanrossum merged commit 02b5ac6 into python:main Nov 29, 2021
@kumaraditya303 kumaraditya303 deleted the test_embed branch November 30, 2021 08:30
@ericsnowcurrently ericsnowcurrently mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kumaraditya303 @gvanrossum @the-knights-who-say-ni @bedevere-bot