bpo-46242: better error message for extending Enum with members - #30357
Merged
Conversation
Member
Author
Here's a commit with this version: 9e7d02c Just to compare. Maybe I even like it more 🤔 |
Member
Author
|
Friendly CC @ethanfurman |
ethanfurman
approved these changes
Jan 14, 2022
Member
|
Thanks, good fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three major changes:
cpython/Lib/enum.py
Lines 850 to 853 in 549e628
_check_for_existing_membersonfirst_enumin_get_mixins_. But, since_get_mixins_is@staticmethod, I've decided not to use explicitEnumType._check_for_existing_members()or not to convert it to@classmethod_create_wrong type was passed to_get_mixins_, instead ofstr,Enumwas passedhttps://bugs.python.org/issue46242