Skip to content

[WIP] bpo-27535: Optimize warnings#4502

Closed
vstinner wants to merge 4 commits intopython:masterfrom
vstinner:warn_optim
Closed

[WIP] bpo-27535: Optimize warnings#4502
vstinner wants to merge 4 commits intopython:masterfrom
vstinner:warn_optim

Conversation

@vstinner
Copy link
Copy Markdown
Member

@vstinner vstinner commented Nov 22, 2017 •
edited by bedevere-bot
Loading

  • bpo-27535: Fix memory leak with warnings ignore
  • bpo-27535: Optimize warnings.warn()
  • C cache
  • warnings.filters becomes an immutable tuple

https://bugs.python.org/issue27535

@vstinner
bpo-27535: Fix memory leak with warnings ignore
4153566 
The warnings module doesn't leak memory anymore in the hidden
warnings registry for the "ignore" action of warnings filters.

The warn_explicit() function doesn't add the warning key to the
registry anymore for the "ignore" action.
@vstinner
bpo-27535: Optimize warnings.warn()
b0c8ad5 
* Optimize warnings.filterwarnings(). Replace re.compile('') with
  None to avoid the cost of calling a regex.match() method, whereas
  it always matchs.
* Optimize get_warnings_attr(): replace PyObject_GetAttrString() with
  _PyObject_GetAttrId().
@vstinner
C cache
3455541
@vstinner
warnings.filters becomes an immutable tuple
caf78aa 
Make it more explicit that warnings.filters must not be replaced
directly, but modified by:

* filterwarning()
* simplefilter()
* resetwarnings()
@vstinner
Copy link
Copy Markdown
Member Author

vstinner commented Nov 22, 2017

Oh, the latest commit "warnings.filters becomes an immutable tuple" broke regrtest --huntrefleak:

haypo@selma$ ./python -m test -R 3:3 test_os -m test_access
Run tests sequentially
0:00:00 load avg: 1.76 [1/1] test_os
beginning 6 repetitions
123456
test test_os crashed -- Traceback (most recent call last):
  File "/home/haypo/prog/python/master/Lib/test/libregrtest/runtest.py", line 178, in runtest_inner
    refleak = dash_R(the_module, test, test_runner, ns.huntrleaks)
  File "/home/haypo/prog/python/master/Lib/test/libregrtest/refleak.py", line 64, in dash_R
    abcs)
  File "/home/haypo/prog/python/master/Lib/test/libregrtest/refleak.py", line 119, in dash_R_cleanup
    warnings.filters[:] = fs
TypeError: 'tuple' object does not support item assignment

@vstinner vstinner mentioned this pull request Nov 23, 2017
Merged
@vstinner
Copy link
Copy Markdown
Member Author

vstinner commented Nov 27, 2017

While the speedup is interesting, these changes are backward incompatible and I'm not sure that it's acceptable. I prefer to close my PR.

@vstinner vstinner closed this Nov 27, 2017
@vstinner vstinner deleted the warn_optim branch November 27, 2017 15:58
@ghost ghost mentioned this pull request Sep 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

awaiting merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner @the-knights-who-say-ni @bedevere-bot