bpo-27535: Cleanup create_filter()#4516
Merged
vstinner merged 2 commits intopython:masterfrom Nov 23, 2017
vstinner:create_filter
Merged
bpo-27535: Cleanup create_filter()#4516vstinner merged 2 commits intopython:masterfrom vstinner:create_filter
vstinner merged 2 commits intopython:masterfrom
vstinner:create_filter
Conversation
create_filter() now expects the action as a _Py_Identifier which avoids string comparison, and more important, to avoid handling the "unknown action" annoying case.
Member
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
It could be possible to replace PyList_SET_ITEM() and create_filter() with a single function or macro and return NULL immediately after error.
Python/_warnings.c
Outdated
| } | ||
|
|
||
| for (x = 0; x < pos; x += 1) { | ||
| for (size_t x = 0; x < pos; x += 1) { |
Member
Author
Maybe, I don't know. I prefer to write a minimum change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create_filter() now expects the action as a _Py_Identifier which
avoids string comparison, and more important, to avoid handling the
"unknown action" annoying case.
https://bugs.python.org/issue27535