[3.6] bpo-27535: Fix memory leak with warnings ignore (GH-4489)#4587
Closed
miss-islington wants to merge 1 commit intopython:3.6from
Closed
[3.6] bpo-27535: Fix memory leak with warnings ignore (GH-4489)#4587miss-islington wants to merge 1 commit intopython:3.6from
miss-islington wants to merge 1 commit intopython:3.6from
Conversation
The warnings module doesn't leak memory anymore in the hidden warnings registry for the "ignore" action of warnings filters. The warn_explicit() function doesn't add the warning key to the registry anymore for the "ignore" action. (cherry picked from commit c975878)
Contributor
Author
|
@vstinner: Backport status check is done, and it's a success ✅ . |
Member
|
This change makes warning.warn() 1.4x slower on Python 3.6 for the ignore action: https://bugs.python.org/issue27535#msg307165 I don't think that the memory leak issue is important enough to justify such slowdown in a stable branch. So I close my PR. |
Contributor
|
this was a very bad decision, now the 3.6 branches leak without most people knowing why. Especially when using botocore when using certain operations. Could someone please find a way to bring this to 3.6 in a performant manner? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The warnings module doesn't leak memory anymore in the hidden
warnings registry for the "ignore" action of warnings filters.
The warn_explicit() function doesn't add the warning key to the
registry anymore for the "ignore" action.
(cherry picked from commit c975878)
https://bugs.python.org/issue27535