Skip to content

bpo-32601: Skip PosixPathTest.test_expanduser if no other user is found - #5246

Merged
serhiy-storchaka merged 1 commit into
python:masterfrom
andersk:test_expanduser
May 14, 2018
Merged

bpo-32601: Skip PosixPathTest.test_expanduser if no other user is found#5246
serhiy-storchaka merged 1 commit into
python:masterfrom
andersk:test_expanduser

Conversation

@andersk

@andersk andersk commented Jan 19, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

This happens in the NixOS build sandbox, for example, where the only other user is nobody with home directory /.

https://bugs.python.org/issue32601

@the-knights-who-say-ni

the-knights-who-say-ni commented Jan 19, 2018

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@andersk andersk changed the title Skip PosixPathTest::test_expanduser if no other user is found bpo-32601: Skip PosixPathTest.test_expanduser if no other user is found Jan 19, 2018
@andersk

andersk commented Mar 1, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

My b.p.o profile (also named andersk) shows that I signed the CLA and linked my GitHub username to it the same day I submitted this PR. Is the bot going to update this?

serhiy-storchaka
serhiy-storchaka reviewed Mar 2, 2018
View reviewed changes
Comment thread Lib/test/test_pathlib.py Outdated

@serhiy-storchaka serhiy-storchaka Mar 2, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will skip the whole test even if most checks are not related to othername.

I would set othername = username and otherhome = userhome or set othername = None and skip only checks for p3.

@serhiy-storchaka serhiy-storchaka added needs backport to 3.6 tests Tests in the Lib/test dir labels Mar 2, 2018
serhiy-storchaka
serhiy-storchaka requested changes May 13, 2018
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole test shouldn't be skipped. Try to test so much as possible with a single user.

@bedevere-bot

bedevere-bot commented May 13, 2018

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@andersk
bpo-32601: Let test_expanduser use the same user if no others found
955cda4 
This happens in the NixOS build sandbox, for example, where the only
other user is nobody with home directory /.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@andersk
andersk force-pushed the test_expanduser branch from bcb2b2a to 955cda4 Compare May 13, 2018 16:28
@andersk

andersk commented May 13, 2018

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again.

@bedevere-bot

bedevere-bot commented May 13, 2018

Copy link
Copy Markdown

Thanks for making the requested changes!

@serhiy-storchaka: please review the changes made to this pull request.

@serhiy-storchaka
serhiy-storchaka merged commit 5c0d462 into python:master May 14, 2018
@miss-islington

miss-islington commented May 14, 2018

Copy link
Copy Markdown
Contributor

Thanks @andersk for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 14, 2018
@andersk @miss-islington
bpo-32601: Let test_expanduser use the same user if no others found. (p…
f4a0001 
…ythonGH-5246)

This happens in the NixOS build sandbox, for example, where the only
other user is nobody with home directory /.
(cherry picked from commit 5c0d462)

Co-authored-by: Anders Kaseorg <andersk@mit.edu>
@bedevere-bot

bedevere-bot commented May 14, 2018

Copy link
Copy Markdown

GH-6792 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 14, 2018
@andersk @miss-islington
bpo-32601: Let test_expanduser use the same user if no others found. (p…
b1720c9 
…ythonGH-5246)

This happens in the NixOS build sandbox, for example, where the only
other user is nobody with home directory /.
(cherry picked from commit 5c0d462)

Co-authored-by: Anders Kaseorg <andersk@mit.edu>
@bedevere-bot

bedevere-bot commented May 14, 2018

Copy link
Copy Markdown

GH-6793 is a backport of this pull request to the 3.6 branch.

@miss-islington

miss-islington commented May 14, 2018

Copy link
Copy Markdown
Contributor

Sorry, @andersk and @serhiy-storchaka, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 5c0d462689e1a69537eaeba6ab94e3ff3524fc31 2.7

miss-islington added a commit that referenced this pull request May 14, 2018
@miss-islington @andersk
bpo-32601: Let test_expanduser use the same user if no others found. (G…
2e01f7d 
…H-5246)

This happens in the NixOS build sandbox, for example, where the only
other user is nobody with home directory /.
(cherry picked from commit 5c0d462)

Co-authored-by: Anders Kaseorg <andersk@mit.edu>
@andersk

andersk commented May 14, 2018

Copy link
Copy Markdown
Contributor Author

There’s no pathlib in 2.7, so no 2.7 backport is needed.

miss-islington added a commit that referenced this pull request May 14, 2018
@miss-islington @andersk
bpo-32601: Let test_expanduser use the same user if no others found. (G…
48fdbbf 
…H-5246)

This happens in the NixOS build sandbox, for example, where the only
other user is nobody with home directory /.
(cherry picked from commit 5c0d462)

Co-authored-by: Anders Kaseorg <andersk@mit.edu>
@serhiy-storchaka

serhiy-storchaka commented May 14, 2018

Copy link
Copy Markdown
Member

Good point! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@andersk @the-knights-who-say-ni @bedevere-bot @miss-islington @serhiy-storchaka @ned-deily