Skip to content

bpo-29708: support SOURCE_DATE_EPOCH for build info #5313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
commodo wants to merge 1 commit into from
Closed

bpo-29708: support SOURCE_DATE_EPOCH for build info #5313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
bpo-29708: support SOURCE_DATE_EPOCH for build info 
The `Modules/getbuildinfo.c` file allows the use of
DATE and TIME macros to be defined via CFLAGS.

These vars, control the build date & time when the
interpreter is opened, and can be read via the
`platform._sys_version()` function.

So, a conversion from SOURCE_DATE_EPOCH to DATE & TIME
is required at build-time.

This is especially needed for `platform._sys_version()`
to work.
The installation of pip seems to rely on this.

The logic has been adapted from:
 https://wiki.debian.org/ReproducibleBuilds/TimestampsProposal#Makefile

Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
  • Loading branch information
@commodo
commodo committed Jan 25, 2018
commit 584429d05cd14f4deb826f39d2f16eb478f75bd7
12 changes: 12 additions & 0 deletions Makefile.pre.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -737,13 +737,25 @@ regen-all: regen-opcode regen-opcode-targets regen-typeslots regen-grammar regen
############################################################################
# Special rules for object files

DATE_FMT = %b %d %Y
TIME_FMT = %H:%M:%S
ifdef SOURCE_DATE_EPOCH
BUILD_DATE ?= $(shell date -u -d "@$(SOURCE_DATE_EPOCH)" "+$(DATE_FMT)" 2>/dev/null || date -u -r "$(SOURCE_DATE_EPOCH)" "+$(DATE_FMT)" 2>/dev/null || date -u "+$(DATE_FMT)")
BUILD_TIME ?= $(shell date -u -d "@$(SOURCE_DATE_EPOCH)" "+$(TIME_FMT)" 2>/dev/null || date -u -r "$(SOURCE_DATE_EPOCH)" "+$(TIME_FMT)" 2>/dev/null || date -u "+$(TIME_FMT)")
else
BUILD_DATE ?= $(shell date "+$(DATE_FMT)")
BUILD_TIME ?= $(shell date "+$(TIME_FMT)")
endif

Modules/getbuildinfo.o: $(PARSER_OBJS) \
$(OBJECT_OBJS) \
$(PYTHON_OBJS) \
$(MODULE_OBJS) \
$(MODOBJS) \
$(srcdir)/Modules/getbuildinfo.c
$(CC) -c $(PY_CORE_CFLAGS) \
-DDATE="\"$(BUILD_DATE)\"" \
-DTIME="\"$(BUILD_TIME)\"" \
-DGITVERSION="\"`LC_ALL=C $(GITVERSION)`\"" \
-DGITTAG="\"`LC_ALL=C $(GITTAG)`\"" \
-DGITBRANCH="\"`LC_ALL=C $(GITBRANCH)`\"" \
Expand Down
4 changes: 4 additions & 0 deletions Misc/NEWS.d/next/Build/2018-01-25-10-35-49.bpo-29708.d97BIE.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Honor the SOURCE_DATE_EPOCH environment variable during build to produce
reproducible binaries. This means using the SOURCE_DATE_EPOCH value to
compute values for the DATE and TIME variables, that will be used in
Modules/getbuildinfo.c