Fix Windows build of Python for latest WinSDK. - #6874
Merged
Conversation
Member
Author
|
The Travis CI failure appears to be spurious; this PR doesn't contain any changes that would affect a non-Windows build. I can add a bugs.python.org issue if that's needed; wasn't sure if this build-system fix met the triviality bar or not. I don't think a news entry should be needed here, but I don't have permission to add the "skip news" label. |
zooba
approved these changes
May 17, 2018
zooba
left a comment
zooba
left a comment
Member
There was a problem hiding this comment.
Thanks! Sorry for not seeing this earlier
Contributor
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 17, 2018
(cherry picked from commit c0ee341) Co-authored-by: Carl Meyer <carl@oddbird.net>
|
GH-6952 is a backport of this pull request to the 3.7 branch. |
Contributor
|
Sorry, @carljm and @zooba, I could not cleanly backport this to |
|
GH-6953 is a backport of this pull request to the 3.6 branch. |
zooba
pushed a commit
that referenced
this pull request
May 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python would not build on a fresh Windows machine with a fresh Visual Studio install. Per @zooba this is because there is a new version of the Windows SDK bundled with latest VS. This issue would not affect anyone upgrading earlier VS versions, only a fresh install.
Confirmed that this fix allows
PCBuild/build.batto complete instead of failing to find the Win SDK.