Skip to content

Conversation

@yashlad681
Copy link
Contributor

@yashlad681 yashlad681 commented May 13, 2022

#gh-91249: Removed .bat when activating venv on windows #91249

I have replaced

 tutorial-env\Scripts\activate.bat -> tutorial-env\Scripts\activate 
Basically removed .bat from script.

Please let me know if this is as expected. Thank you

@yashlad681 yashlad681 requested a review from vsajip as a code owner May 13, 2022 10:05
@ghost
Copy link

ghost commented May 13, 2022

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot
Copy link

Every change to Python requires a NEWS entry.

Please, add it using the blurb_it Web app or the blurb command-line tool.

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels May 13, 2022
@vsajip
Copy link
Member

vsajip commented May 13, 2022

There's no real need for this, is there?

@vsajip vsajip closed this May 13, 2022
@yashlad681
Copy link
Contributor Author

Hi, I modified it since in comments mentioned this earlier

For windows, tutorial-env\Scripts\activate.bat doesn't appear to set up venv successfully.

And so I modified it.
Thank you

@vsajip
Copy link
Member

vsajip commented May 13, 2022

For windows, tutorial-env\Scripts\activate.bat doesn't appear to set up venv successfully

That's a bit too vague. I'd suggest asking questions on e.g. the Python discussion forum or Stack Overflow, to see if there's some reason why things don't work as you'd expect.

@yashlad681
Copy link
Contributor Author

Will do, thank you for clarifying.

@yashlad681 yashlad681 deleted the modifyingWindowsVenvScript branch May 13, 2022 10:45
@yashlad681 yashlad681 restored the modifyingWindowsVenvScript branch May 13, 2022 10:51
@AlexWaygood
Copy link
Member

@yashlad681, in the future, if you're trying to fix a specific issue in a PR, I'd recommend mentioning the issue number in the PR title (e.g. gh-91249), and probably also in the PR description. Otherwise, it can be very unclear what problem you're trying to fix. Thanks!

@yashlad681
Copy link
Contributor Author

Hey @AlexWaygood , sure noted.

@vsajip
Copy link
Member

vsajip commented May 13, 2022

Right, I hadn't realized there was actually an issue around this.

@vsajip vsajip reopened this May 13, 2022
@bedevere-bot
Copy link

Every change to Python requires a NEWS entry.

Please, add it using the blurb_it Web app or the blurb command-line tool.

@vsajip vsajip changed the title Removed .bat when activating venv on windows gh-91249: Remove .bat extension in documentation for when activating venv on Windows. May 13, 2022
@vsajip vsajip changed the title gh-91249: Remove .bat extension in documentation for when activating venv on Windows. gh-91249: Remove .bat extension in documentation for when activating venv on Windows. (GH-92770) May 13, 2022
@vsajip vsajip merged commit 3115c2c into python:main May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants