gh-96670: Raise SyntaxError when parsing NULL bytes#97594
Conversation
97a8f83 to
cb89392
Compare
gvanrossum
left a comment
gvanrossum
left a comment
There was a problem hiding this comment.
What's up with python3.12.abi.new having 22,644 additions?
gvanrossum
left a comment
gvanrossum
left a comment
There was a problem hiding this comment.
LG except for one word in an error message, I think.
Wow, that's some error. Let me clean that up |
Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
|
Ugh, force-push. :-( |
gvanrossum
left a comment
gvanrossum
left a comment
There was a problem hiding this comment.
I see nothing else wrong, let's wait for Lysandros' LGTM.
|
I was going to ask "doesn't this break things for encodings where NULLs are normal, like UTF-16", but then realized we never supported that anyway: PEP 253: "It does not include encodings which use two or more bytes for all characters like e.g. UTF-16. The reason for this is to keep the encoding detection algorithm in the tokenizer simple." In that sense, we get a better error message for UTF-16 files with this PR than before. Prior, it would silently fail (behave as if an empty file), and with this PR: |
|
Landing, thank you everyone for your great review and comments! And also thank @mdboom for checking the UTF-16, that was a good consideration :) P.S. Sorry for the force push :S |
…honGH-97594). (cherry picked from commit aab01e3) Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
|
GH-104195 is a backport of this pull request to the 3.11 branch. |
5 participants
Uh oh!
There was an error while loading. Please reload this page.