Skip to content

gh-1194: Add Windows command for patchcheck to Quick Reference #1195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ambv merged 2 commits into from
Oct 19, 2023
Merged

gh-1194: Add Windows command for patchcheck to Quick Reference #1195

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1cbabf0
Update index.rst
fipachu Oct 17, 2023
885cdff
Put OS specific instructions on their own lines
fipachu Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,19 @@ instructions please see the :ref:`setup guide <setup>`.
<https://github.com/python/cpython/issues>`_. Trivial issues (e.g. typo fixes) do
not require any issue to be created.

6. Once you fixed the issue, run the tests, run ``make patchcheck``, and if
everything is ok, commit.
6. Once you fixed the issue, run the tests, and the patchcheck.

On Unix and macOS use::

make patchcheck

and on Windows:

.. code-block:: dosbatch

.\python.bat Tools\patchcheck\patchcheck.py

If everything is ok, commit.

7. Push the branch on your fork on GitHub and :ref:`create a pull request
<pullrequest>`. Include the issue number using ``gh-NNNN`` in the
Expand Down