Skip to content

Add guidelines for triagers closing PRs #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brettcannon merged 9 commits into from
Sep 11, 2019
Merged

Add guidelines for triagers closing PRs #530

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7650fbc
Add guidelines for triagers closing PRs
aeros Aug 24, 2019
6caf6d4
Fix indentation level
aeros Aug 24, 2019
cc83c00
Add mariatta's suggestions
aeros Aug 29, 2019
fe7434e
Clarify closing guidelines
aeros Aug 30, 2019
278c524
Add suggestion from ammaraskar and improve phrasing
aeros Aug 31, 2019
5375420
Remove reST note directive
aeros Aug 31, 2019
1f23826
Remove stale label section
aeros Aug 31, 2019
62f1f9e
Apply suggestions from willingc
aeros Sep 2, 2019
93554a0
Apply suggestions from willingc
aeros Sep 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions triaging.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ Responsibilities include:
* PR/issue management
- Renaming PRs
- Reviewing PRs
- Closing PRs and issues
- Assisting contributors
- Notifying appropriate core developers
* Applying appropriate labels to PRs/Issues
Expand All @@ -37,6 +36,16 @@ Responsibilities include:
- Good first issue
- Other categorizations

As triagers gain experience, they may have some intuition of when a PR should
be closed. Triagers can recommend closing a PR, but the final decision must be
made by a core developer. By having triagers and core developers work together,
the author receives a careful consideration of their PR. This encourages future
contributions, regardless of whether their PR is accepted or closed.

Triagers can make use of the ``invalid`` and ``stale`` labels to suggest that a
PR may be suitable for closure. For more information, see the
:ref:`GitHub PR labels <github-pr-labels>` section.

It is also of paramount importance to treat every contributor to the Python
project kindly and with respect. Regardless of whether they're entirely new
or a veteran core developer, they're actively choosing to voluntarily donate their
Expand Down Expand Up @@ -72,6 +81,7 @@ For every new triager, it would be great to announce them in the python-committe
mailing list and core-workflow category in Discourse. `Example announcement
<https://discuss.python.org/t/abhilash-raj-has-been-granted-triage-role-on-github/2089>`_.

.. _github-pr-labels:

GitHub Labels for PRs
'''''''''''''''''''''
Expand All @@ -93,8 +103,9 @@ expert-asyncio
invalid
Used manually for PRs that do not meet basic requirements and
automatically added by bedevere when PR authors attempt to merge maintenace
branches into the master branch. During competitions, this label causes the
PR to not count towards the author's contributions.
branches into the master branch. During events such as the October
Hacktoberfest, this label will prevent the PR from counting toward the
author's contributions.

needs backport to X.Y
Used for PRs which are appropriate to backport to
Expand Down