Don't immediately delete PR's branch in case it's close&reopen - #483
Merged
Conversation
Contributor
Author
|
After a second thought, perhaps the sleep should be lower? Like 15 seconds? |
Contributor
Author
|
I have to update tests here. |
Codecov Report
@@ Coverage Diff @@
## main #483 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 983 1009 +26
Branches 69 71 +2
=========================================
+ Hits 983 1009 +26
|
Contributor
Author
Done. |
Mariatta
approved these changes
May 12, 2022
Mariatta
left a comment
Member
There was a problem hiding this comment.
I think this is a great solution.
Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #70
Alternatively, we could create a task and add a listener for
reopenthat will cancel the existing task if one exists.