Skip to content

Don't immediately delete PR's branch in case it's close&reopen - #483

Merged
Mariatta merged 7 commits into
python:mainfrom
Jackenmen:patch-3
May 12, 2022
Merged

Don't immediately delete PR's branch in case it's close&reopen#483
Mariatta merged 7 commits into
python:mainfrom
Jackenmen:patch-3

Conversation

@Jackenmen

Copy link
Copy Markdown
Contributor

Fixes #70

Alternatively, we could create a task and add a listener for reopen that will cancel the existing task if one exists.

@Jackenmen

Copy link
Copy Markdown
Contributor Author

After a second thought, perhaps the sleep should be lower? Like 15 seconds?

@Jackenmen

Copy link
Copy Markdown
Contributor Author

I have to update tests here.

@codecov

codecov Bot commented Apr 15, 2022

Copy link
Copy Markdown

Codecov Report

Merging #483 (9498225) into main (8569d62) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #483   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          983      1009   +26     
  Branches        69        71    +2     
=========================================
+ Hits           983      1009   +26     
Impacted Files Coverage Δ
miss_islington/delete_branch.py 100.00% <100.00%> (ø)
tests/test_delete_branch.py 100.00% <100.00%> (ø)

@Jackenmen

Copy link
Copy Markdown
Contributor Author

I have to update tests here.

Done.

@Mariatta Mariatta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a great solution.
Thank you!

@Mariatta
Mariatta merged commit 30c4a00 into python:main May 12, 2022
@Jackenmen
Jackenmen deleted the patch-3 branch May 12, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Odd backport failure

4 participants