Skip to content

stubtest: error if an attribute is a read-only property at runtime, but isn't read-only in the stub #12291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hauntsaninja merged 5 commits into from
Mar 21, 2022
Merged

stubtest: error if an attribute is a read-only property at runtime, but isn't read-only in the stub #12291

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c8d8a14
stubtest: error if an attribute is a read-only property at runtime, b…
AlexWaygood Mar 4, 2022
481cea5
Simplify
AlexWaygood Mar 4, 2022
8134f4f
Fix typo
AlexWaygood Mar 4, 2022
d2db2f5
Add another test case
AlexWaygood Mar 5, 2022
841aa1b
Remove duplication in test cases
AlexWaygood Mar 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix typo
  • Loading branch information
@AlexWaygood
AlexWaygood authored Mar 4, 2022
commit 8134f4f49e03701a63c58c5b18e6ea78b9bd9672
2 changes: 1 addition & 1 deletion mypy/stubtest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1060,7 +1060,7 @@ def is_probably_a_function(runtime: Any) -> bool:


def is_read_only_property(runtime: object) -> bool:
return isinstance(runtime, property) and property.fset is None
return isinstance(runtime, property) and runtime.fset is None


def safe_inspect_signature(runtime: Any) -> Optional[inspect.Signature]:
Expand Down