Skip to content

stubtest: emit error if a stub defines a public type alias that doesn't exist at runtime #12608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hauntsaninja merged 5 commits into from
Apr 18, 2022
Merged

stubtest: emit error if a stub defines a public type alias that doesn't exist at runtime #12608

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
95cd2f1
stubtest: emit error if a stub defines a public type alias that's mis…
AlexWaygood Apr 17, 2022
42b9648
Use `fullname` instead of `name`
AlexWaygood Apr 17, 2022
5f12a98
undo some reporting changes
Apr 18, 2022
b4ee9d1
new reporting
Apr 18, 2022
378d3d2
Update mypy/stubtest.py
hauntsaninja Apr 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
new reporting
  • Loading branch information
hauntsaninja committed Apr 18, 2022
commit b4ee9d1bdf34415a30b261fa1469817ec795e40c
3 changes: 2 additions & 1 deletion mypy/stubtest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -959,7 +959,8 @@ def verify_typealias(
stub_target = mypy.types.get_proper_type(stub.target)
if isinstance(runtime, Missing):
yield Error(
object_path, "is not present at runtime", stub_target, runtime, typealias_node=stub
object_path, "is not present at runtime", stub, runtime,
stub_desc=f"Type alias for {stub_target}"
)
return
if isinstance(stub_target, mypy.types.Instance):
Expand Down