Skip to content

mypy_primer: truncate per-project output #14091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hauntsaninja merged 3 commits into from
Nov 18, 2022
Merged

mypy_primer: truncate per-project output #14091

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c1c2e05
mypy_primer: truncate per-project output
ikonst Nov 14, 2022
15eeecd
improve truncation
ikonst Nov 14, 2022
6824fdd
Update .github/workflows/mypy_primer_comment.yml
hauntsaninja Nov 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
improve truncation
  • Loading branch information
@ikonst
ikonst committed Nov 14, 2022
commit 15eeecd8751296536b95b673cd7fd55166f5870f
14 changes: 8 additions & 6 deletions .github/workflows/mypy_primer_comment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,13 +54,15 @@ jobs:
const fs = require('fs')
let data = fs.readFileSync('fulldiff.txt', { encoding: 'utf8' })

function truncateIfNeeded(s, maxLength) {
let truncated = s.substring(0, maxLength)
if (s.length === truncated.length) {
return s
function truncateIfNeeded(original, maxLength) {
let truncated = original.substring(0, maxLength)
if (original.length === truncated.length) {
return original
}
let lines_truncated = s.split('\n').length - truncated.split('\n').length
return `${truncated}\n\n... (truncated ${lines_truncated} lines) ...\n`
// further, remove last line that might be truncated
truncated = truncated.substring(0, truncated.lastIndexOf('\n'))
let lines_truncated = original.split('\n').length - truncated.split('\n').length
return `${truncated}\n\n... (truncated ${lines_truncated} lines) ...`
}

const projects = data.split('\n\n')
Expand Down