shellcheck: add workflow, shellcheck fix the scripts#14905
Open
yarikoptic wants to merge 3 commits into
Open
Conversation
=== Do not change lines below ===
{
"chain": [],
"cmd": "shellcheckit doit -f diff | git apply",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
codespell complained
In misc/test-stubgenc.sh line 15:
rm -rf $STUBGEN_OUTPUT_FOLDER/*
^----------------------^ SC2115 (warning): Use "${var:?}" to ensure this never expands to /* .
For more information:
https://www.shellcheck.net/wiki/SC2115 -- Use "${var:?}" to ensure this nev...
so I followed the recommendation and also ""quoted the value use later in the lines.
In principle that is all not required ATM since the value is hardcoded in the script BUT
happen the value changes, and e.g. variable name gets changed or mystyped without correct
changes to uses -- someone might end up in pain while triggering all those gotchas. With
these changes code becomes safer and thus preferable imho.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Request to shellcheck contribution was given in #13284 recently. Project has some shell scripts but they are not checked by CI . This PR does both - adds CI, and
Individual commits would have more explanation and provenance on changes.