Skip to content

Fixes #2589: type redeclarations cause spurious warnings #2591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JukkaL merged 1 commit into from
Dec 22, 2016
Merged

Fixes #2589: type redeclarations cause spurious warnings #2591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions mypy/semanal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1309,10 +1309,11 @@ def analyze_lvalue(self, lval: Lvalue, nested: bool = False,
lval.kind = MDEF
lval.fullname = lval.name
self.type.names[lval.name] = SymbolTableNode(MDEF, v)
elif explicit_type:
# Don't re-bind types
self.name_already_defined(lval.name, lval)
else:
# Bind to an existing name.
if explicit_type:
self.name_already_defined(lval.name, lval)
lval.accept(self)
self.check_lvalue_validity(lval.node, lval)
elif isinstance(lval, MemberExpr):
Expand Down
10 changes: 10 additions & 0 deletions test-data/unit/semanal-errors.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1311,3 +1311,13 @@ class A:
[out]
main:5: error: Name 'x' is not defined
main:5: error: Name 'y' is not defined

[case testTypeRedeclarationNoSpuriousWarnings]
from typing import Tuple
a = 1 # type: int
a = 's' # type: str
a = ('spam', 'spam', 'eggs', 'spam') # type: Tuple[str]

[out]
main:3: error: Name 'a' already defined
main:4: error: Name 'a' already defined