fix find_in_po. Make it Windows compatible - #2714
Merged
Merged
Conversation
Co-authored-by: Marco Richetta <marco.richetta@mercadolibre.com>
Collaborator
Author
|
@marcorichetta gracias por la sugerencia. Toda la razón my friend! |
marcorichetta
approved these changes
Oct 27, 2023
rtobar
reviewed
Oct 28, 2023
rtobar
left a comment
rtobar
left a comment
Collaborator
There was a problem hiding this comment.
Aún no entiendo por qué el except no estaba funcionando cuando debiera haber atrapado el error de que no hacía un programa stty en Windows, pero al menos esto abrió una buena discusión. Acá dejo mi comentario, creo que este código se puede simplificar aún más
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use os.get_terminal_size() instead of stty size for width