Conversation
Member
Author
|
Context of this PR, see: MagicStack/immutables#64 |
The COPYING file was copied from https://github.com/psf/pyperf/ without updating the copyright. Follow recommendations of the Linux Foundation: https://www.linuxfoundation.org/en/blog/copyright-notices-in-open-source-software-projects/
Member
Author
|
I updated the PR to use "Copyright Contributors to the pythoncapi_compat project." which is recommended by the Linux Foundation. |
Member
Author
corona10
approved these changes
Apr 22, 2021
elprans
approved these changes
Apr 22, 2021
elprans
approved these changes
Apr 22, 2021
elprans
left a comment
elprans
left a comment
There was a problem hiding this comment.
Perhaps also copy the full text of the MIT license to the comment header?
Member
Author
Nah, I'm lazy :-D IMO "File distributed under the MIT license." and "SPDX-License-Identifier: MIT" is enough. |
Member
Author
|
Thanks for the reviews! I'm never comfortable with licenses and copyright :-( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The COPYING file was copied from https://github.com/psf/pyperf/
without updating the copyright.
Follow recommendations of the Linux Foundation:
https://www.linuxfoundation.org/en/blog/copyright-notices-in-open-source-software-projects/