Use bool | Literal[0, 1] instead of int in some tkinter bool parameters
#11412
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a less disruptive version of #11394.
In general, passing 0 or 1 is less readable and just not the right thing to do in new code. Users should just use the new and readable thing instead of the confusing legacy thing. Tkinter (and much of its documentation) was created before
boolwas added to Python.That said, there's still plenty of example code around (e.g. stackoverflow answers, tkinter docstrings) that use 0 and 1. IMO we should apply
Literal[0, 1]to tkinter booleans only when someone needs it in a specific place, not blindly to all boolean parameters.This is also why I don't want yet another type alias, e.g.
_TkBool = bool | Literal[0, 1]. In most cases, it's not the right thing to use, so I don't want a convenience thing for it.