Add missing encoding arg to check_call and call to match POpen#12086
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
sobolevn
reviewed
Jun 6, 2024
sobolevn
left a comment
sobolevn
left a comment
Member
There was a problem hiding this comment.
check_call calls call, which does not have encoding= in stubs right now.
Contributor
Author
Let me fix that. |
Contributor
Author
Fixed: d0d2bd4 |
max-muoto
changed the title
encoding arg to check_call to match POpenencoding arg to check_call and call to match POpen
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
@sobolevn Just following up on this one. |
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
sobolevn
approved these changes
Jun 23, 2024
srittau
approved these changes
Jun 23, 2024
max-muoto
added a commit
to max-muoto/typeshed
that referenced
this pull request
Sep 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12084