Update tkinter photo image - #12342
Merged
Merged
Conversation
max-muoto
commented
Jul 14, 2024
| def copy( | ||
| self, | ||
| *, | ||
| from_coords: Iterable[int] | None = None, |
Contributor
Author
There was a problem hiding this comment.
Using Iterable for anything that is simply star unpacked.
This comment has been minimized.
This comment has been minimized.
Akuli
reviewed
Jul 14, 2024
Akuli
left a comment
Akuli
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for working on this! Tkinter is more tricky than you would expect it to be :)
max-muoto
marked this pull request as ready for review
July 14, 2024 18:41
This comment has been minimized.
This comment has been minimized.
Akuli
reviewed
Jul 14, 2024
Akuli
left a comment
Akuli
left a comment
Collaborator
There was a problem hiding this comment.
I noticed one more thing :)
Akuli
reviewed
Jul 14, 2024
Co-authored-by: Akuli <akuviljanen17@gmail.com>
Contributor
Author
Want to confirm, this looks good to you? #12342 (comment) |
Collaborator
|
Yes, it seems good :) |
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
max-muoto
added a commit
to max-muoto/typeshed
that referenced
this pull request
Jul 23, 2024
Co-authored-by: Akuli <akuviljanen17@gmail.com>
max-muoto
added a commit
to max-muoto/typeshed
that referenced
this pull request
Sep 8, 2024
Co-authored-by: Akuli <akuviljanen17@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.