Merged
Conversation
This covers darwin. Linux and win32 will need cleanup still.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
approved these changes
Nov 21, 2024
Collaborator
Platform checks are preferable, in my opinion. Back in 2018, we didn't have |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another messy
__all__. I tried to order the branches in a systematic way of increasing complexity: first version_info checks, then single platform and their versions, sorted alphabetically, then negative checks, then combinations, thenorstatements. No nesting the branches except where unavoidable (for complicatedand/orconditions).Side note, how are feeling about the precedent from #2286 to not use sys.platform checks on
os.O_*? Some of them are certainly correct to be that way, but I feel like it's a little silly to not use the check when we can be confident about it.