[yt-dlp] Make _Params["paths"] a Mapping[str, str]#14998
Open
Marcin795 wants to merge 1 commit intopython:mainfrom
Open
[yt-dlp] Make _Params["paths"] a Mapping[str, str]#14998Marcin795 wants to merge 1 commit intopython:mainfrom
Marcin795 wants to merge 1 commit intopython:mainfrom
Conversation
`paths` accepts a dict of output paths (keys: 'home', 'temp', and OUTTMPL_TYPES keys). Typing it as `Mapping[str, str] | None` matches runtime behavior and avoids false positives when passing a dict to YoutubeDL params.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Collaborator
|
Considering that it must be a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pathsaccepts a dict of output paths (keys: 'home', 'temp', and OUTTMPL_TYPES keys). Typing it asMapping[str, str] | Nonematches runtime behavior and avoids false positives when passing a dict to YoutubeDL params.pathskey description in YoutubeDL.py:Dictionary of output paths. The allowed keys are 'home', 'temp' and the keys of OUTTMPL_TYPES (in utils/_utils.py)
It's also asserted to be a
dictinget_output_path:assert isinstance(paths, dict), '"paths" parameter must be a dictionary'