Skip to content

Fix tkinter subsample and zoom method signatures#15869

Merged
Akuli merged 1 commit into
python:mainfrom
AsfhtgkDavid:tkinter-subsample-and-zoom-fix
Jun 6, 2026
Merged

Fix tkinter subsample and zoom method signatures#15869
Akuli merged 1 commit into
python:mainfrom
AsfhtgkDavid:tkinter-subsample-and-zoom-fix

Conversation

@AsfhtgkDavid

Copy link
Copy Markdown
Contributor

This PR fixes an incorrect annotation for the y argument in the subsample and zoom methods. According to the documentation, by default it accepts an empty string and is then set to x, but it can be changed independently. This bug has been present since version 3.13+.

@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@Akuli Akuli left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@Akuli
Akuli merged commit df676eb into python:main Jun 6, 2026
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants