Add constructor for HTTPError in urllib2/urllib.error#2373
Merged
JelleZijlstra merged 1 commit intoAug 9, 2018
Conversation
It seems that code using HTTPError previously worked by accident because we used to accept arbitrary keyword arguments when instantiating BaseException, or any subclass of BaseException (see python#2348). This commit adds in the correct constructor (which also lets the user specify the arguments in keyword-argument form). Note: I'm not very familiar with the urllib libraries, so I opted to just add the signature and leave it up to somebody else to fill in the types.
JelleZijlstra
approved these changes
Aug 9, 2018
yedpodtrzitko
pushed a commit
to yedpodtrzitko/typeshed
that referenced
this pull request
Jan 23, 2019
It seems that code using HTTPError previously worked by accident because we used to accept arbitrary keyword arguments when instantiating BaseException, or any subclass of BaseException (see python#2348). This commit adds in the correct constructor (which also lets the user specify the arguments in keyword-argument form). Note: I'm not very familiar with the urllib libraries, so I opted to just add the signature and leave it up to somebody else to fill in the types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that code passing in keyword arguments when instantiating HTTPError previously worked by accident because we used to accept arbitrary keyword arguments when instantiating BaseException, or any subclass of BaseException (see #2348).
This is no longer the case, due to the change made in the PR linked up above.
This commit adds in the correct constructor (which also lets the user specify the arguments in keyword-argument form).
Note: I'm not very familiar with the urllib libraries, so I opted to just add the signature and leave it up to somebody else to fill in the types.