socket: setblocking(int) #4634
Closed
socket: setblocking(int) #4634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of `bool`, as there are many contradicting signatures: <https://docs.python.org/3/library/socket.html#socket.socket.setblocking> names the arguments `flags` and uses `false` in the descriptive text, but uses `bool` in the given examples. <https://github.com/python/cpython/blob/master/Modules/socketmodule.c#L149> uses `bool` in the module documentation, but the internal wrapper in <https://github.com/python/cpython/blob/master/Modules/socketmodule.c#L658> uses `int` which is called by the public function in <https://github.com/python/cpython/blob/master/Modules/socketmodule.c#L2783> using `PyLong_AsLong()` to get the value of `flags` as an `int`. So `int` is correct as `bool` is a subtype of it and gets promoted to it automatically. Signed-off-by: Philipp Hahn <hahn@univention.de>
Collaborator
|
I'm -1 on this change. The argument is clearly used as a boolean value. With the same justification we could change nearly all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of
bool, as there are many contradicting signatures:https://docs.python.org/3/library/socket.html#socket.socket.setblocking
names the arguments
flagsand usesfalsein the descriptive text,but uses
boolin the given examples.https://github.com/python/cpython/blob/master/Modules/socketmodule.c#L149
uses
boolin the module documentation, but the internal wrapper inhttps://github.com/python/cpython/blob/master/Modules/socketmodule.c#L658
uses
int, which is called by the public function inhttps://github.com/python/cpython/blob/master/Modules/socketmodule.c#L2783
using
PyLong_AsLong()to get anint.So
intis correct asboolis a subtype of it and gets promoted to itautomatically.
Signed-off-by: Philipp Hahn hahn@univention.de