Skip to content

tkinter: use bool instead of Literal[0, 1] #4901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
srittau merged 2 commits into from
Jan 5, 2021
Merged

tkinter: use bool instead of Literal[0, 1] #4901

srittau merged 2 commits into from
Jan 5, 2021

Conversation

@Akuli
Copy link
Collaborator

@Akuli Akuli commented Jan 5, 2021

Similar to #4669

@Akuli
Copy link
Collaborator Author

Akuli commented Jan 5, 2021 •
edited
Loading

I reverted #4765. It should no longer be necessary because #4669 is fixed.

Edit: I don't think that's a good idea, because #4765 also makes the old example code in tkinter's docstrings work.

@Akuli Akuli force-pushed the bool branch 3 times, most recently from b1ecc40 to 8bf52f3 Compare January 5, 2021 12:11
@srittau srittau merged commit 2691d74 into python:master Jan 5, 2021
@Akuli Akuli deleted the bool branch January 5, 2021 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srittau srittau srittau approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Akuli @srittau