Clarify why csv stub has no __version__ attribute#6398
Merged
Akuli merged 4 commits intopython:masterfrom Nov 27, 2021
Merged
Conversation
Collaborator
|
I don't think we should add this. Python defines it as a hard-coded Edit: It might be good to instead add a comment about why |
This comment has been minimized.
This comment has been minimized.
AlexWaygood
changed the title
__version__ attribute to csv.pyicsv stub has no __version__ attribute
AlexWaygood
force-pushed
the
csv-version
branch
from
9cd781d to
4b9b415
Compare
Akuli
reviewed
Nov 27, 2021
Co-authored-by: Akuli <akuviljanen17@gmail.com>
Akuli
approved these changes
Nov 27, 2021
This comment has been minimized.
This comment has been minimized.
1 similar comment
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.