Merged
Conversation
Fixes python#8778 Note that not fixing this has some advantages, particularly if stubsabot waits a little while after releases before making PRs (as discussed earlier). Specifically, it gives us more coverage of upstream versions and might provide a natural division of changes, compared to PRs that make updates corresponding to several upstream versions.
AlexWaygood
approved these changes
Sep 30, 2022
Member
|
Seems like this didn't work. |
Member
|
Logs say |
Collaborator
Author
|
Was surprised by this. The git commands still seem to do the right thing for me, opened #8850 to see what's going on |
Member
Yeah, I tried it out locally as well when I reviewed it, it seemed fine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8778
Note that not fixing this has some advantages, particularly if stubsabot waits a little while after releases before making PRs (as discussed earlier). Specifically, it gives us more coverage of upstream versions and might provide a natural division of changes, compared to PRs that make updates corresponding to several upstream versions.