conformance: fix TypeIs case#2298
Merged
Merged
Conversation
Strictly, the inferred type in the old code should be `tuple[str, ...] & ~tuple[str, str]`: that is, a tuple full of strs of any length that is not 2. Currently no type checker actually infers this type, but I'm working on a change to pycroscope that will make it fail this test. ty also infers the negation type, but passes the test because the conformance suite turns off the specific "assert-type-unspellable-subtype" error code.
davidhalter
approved these changes
Jun 1, 2026
AlexWaygood
approved these changes
Jun 1, 2026
AlexWaygood
added
the
topic: conformance tests
rchen152
approved these changes
Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strictly, the inferred type in the old code should be
tuple[str, ...] & ~tuple[str, str]: that is,a tuple full of strs of any length that is not 2. Currently no type checker actually infers this
type, but I'm working on a change to pycroscope (JelleZijlstra/pycroscope#505) that will make it fail this test.
ty also infers the negation type, but passes the test because the conformance suite turns off
the specific "assert-type-unspellable-subtype" error code.
The new code in the test case does not rely on ambiguous negation type behavior.