-
Notifications
You must be signed in to change notification settings - Fork 191
Add proposal API #473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add proposal API #473
Conversation
|
Can you add sample request and response ? |
junction/proposals/serializers.py
Outdated
| class Meta: | ||
| model = Proposal | ||
| fields = ('id', 'title', 'author', 'slug', 'description', 'target_audience', | ||
| 'prerequisites', 'content_urls', 'speaker_info', 'speaker_links', 'comments') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add Proposal Type and section ?
|
Sample RR. |
|
Changes Unknown when pulling 1362ae0 on ChillarAnand:api into * on pythonindia:master*. |
|
Changes Unknown when pulling 1362ae0 on ChillarAnand:api into * on pythonindia:master*. |
| "content_urls": "", | ||
| "speaker_info": "", | ||
| "speaker_links": "", | ||
| "comments": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend not to add the comments in the list api, either a separate endpoint to fetch the comments of a proposal or can be included in the detail of a proposal.
e.g. /proposals/12/comments which will be paginated resource.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. We can remove from list api. I guess we can add to proposal detail api.
junction/proposals/api.py
Outdated
|
|
||
| class StandardResultsSetPagination(PageNumberPagination): | ||
| page_size = 2 | ||
| page_size_query_param = 'page' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should follow a global configuration unless an exception is required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
@ChillarAnand Is all the changes made? |
|
Yes @kracekumar |
closes #462