Move Metadata from setup.py to setup.cfg #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ernavdeepkr
force-pushed
the
master
branch
2 times, most recently
from
d0b3777 to
186f1f5
Compare
digitronik
requested changes
Mar 28, 2020
Member
There was a problem hiding this comment.
@ernavdeepkr thanks for PR 👍
Some optional and one required comment. Please have a glance.
ernavdeepkr
force-pushed
the
master
branch
2 times, most recently
from
0e6ebec to
0f6b73b
Compare
digitronik
approved these changes
Mar 29, 2020
Member
digitronik
left a comment
digitronik
left a comment
There was a problem hiding this comment.
Thanks LGTM 👍
before merge can you please squash commits?
Signed-off-by: Navdeep Kaur <ernavdeepkr@gmail.com>
Contributor
Author
|
Rebased with upstream and fixup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move Metadata from setup.py to setup.cfg
fixes #25
Signed-off-by: Navdeep Kaur ernavdeepkr@gmail.com