Skip to content

fix: support int64 indices for embedding - #4447

Open
fs-eire wants to merge 2 commits into
pytorch:mainfrom
fs-eire:embedding-int64-indices
Open

fix: support int64 indices for embedding#4447
fs-eire wants to merge 2 commits into
pytorch:mainfrom
fs-eire:embedding-int64-indices

Conversation

@fs-eire

@fs-eire fs-eire commented Jul 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Allow embedding conversion to accept TensorRT int32 and int64 indices.

There used to be a restriction that TensorRT v8.x only works with int32 indices for embedding op, but since TensorRT v9, int64 is supported. We no longer need to reject int64 indices now.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@meta-cla meta-cla Bot added the cla signed label Jul 30, 2026
@github-actions github-actions Bot added component: tests Issues re: Tests component: conversion Issues re: Conversion stage component: core Issues re: The core compiler component: converters Issues re: Specific op converters component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Jul 30, 2026
@github-actions
github-actions Bot requested a review from zewenli98 July 30, 2026 07:01
@narendasan
narendasan requested a review from micwill755 July 31, 2026 19:10
micwill755
micwill755 reviewed Aug 3, 2026
View reviewed changes
Comment thread tests/py/dynamo/conversion/test_embedding_aten.py
zewenli98
zewenli98 approved these changes Aug 4, 2026
View reviewed changes

@zewenli98 zewenli98 left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. waiting for CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@micwill755 micwill755 micwill755 left review comments
@zewenli98 zewenli98 zewenli98 approved these changes

Assignees

No one assigned

Labels

cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: core Issues re: The core compiler component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fs-eire @zewenli98 @micwill755