fix stack overread on truncated range in cpulist parse_entry - #431
fix stack overread on truncated range in cpulist parse_entry#431soma0212 wants to merge 1 commit into
Conversation
|
Hi @soma0212! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
parse_entry dereferences number_start without checking that anything actually follows the '-':
Bailing out before the dereference leaves the entry rejected exactly as it already was, so the callback sequence and return value are the same on every input I tried, valid or malformed.