[5/N] Add get_option/set_option APIs#11758
[5/N] Add get_option/set_option APIs#11758cccclai wants to merge 7 commits intogh/cccclai/29/basefrom
Conversation
Differential Revision: [D76825663](https://our.internmc.facebook.com/intern/diff/D76825663/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11758
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 2 Unrelated FailuresAs of commit cfb760b with merge base 608a745 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Differential Revision: [D76825663](https://our.internmc.facebook.com/intern/diff/D76825663/) ghstack-source-id: 290994800 Pull Request resolved: #11758
|
This pull request was exported from Phabricator. Differential Revision: D76825663 |
This PR needs a
|
Expose the API to set/get backend option. We can either pass in {backend_name, backend options} or {backend options map}
Differential Revision: [D76825663](https://our.internmc.facebook.com/intern/diff/D76825663/)
Differential Revision: [D76825663](https://our.internmc.facebook.com/intern/diff/D76825663)
[ghstack-poisoned]
Pull Request resolved: #11758 ghstack-source-id: 290994800 Expose the API to set/get backend option. We can either pass in {backend_name, backend options} or {backend options map} Differential Revision: [D76825663](https://our.internmc.facebook.com/intern/diff/D76825663/)
|
This pull request was exported from Phabricator. Differential Revision: D76825663 |
Expose the API to set/get backend option. We can either pass in {backend_name, backend options} or {backend options map}
Differential Revision: [D76825663](https://our.internmc.facebook.com/intern/diff/D76825663/)
Differential Revision: [D76825663](https://our.internmc.facebook.com/intern/diff/D76825663)
[ghstack-poisoned]
Pull Request resolved: #11758 ghstack-source-id: 290994800 Expose the API to set/get backend option. We can either pass in {backend_name, backend options} or {backend options map} Differential Revision: [D76825663](https://our.internmc.facebook.com/intern/diff/D76825663/)
|
This pull request was exported from Phabricator. Differential Revision: D76825663 |
Expose the API to set/get backend option. We can either pass in {backend_name, backend options} or {backend options map}
Differential Revision: [D76825663](https://our.internmc.facebook.com/intern/diff/D76825663/)
Differential Revision: [D76825663](https://our.internmc.facebook.com/intern/diff/D76825663)
[ghstack-poisoned]
Pull Request resolved: #11758 ghstack-source-id: 290994800 Expose the API to set/get backend option. We can either pass in {backend_name, backend options} or {backend options map} Differential Revision: [D76825663](https://our.internmc.facebook.com/intern/diff/D76825663/)
|
This pull request was exported from Phabricator. Differential Revision: D76825663 |
Expose the API to set/get backend option. We can either pass in {backend_name, backend options} or {backend options map}
Differential Revision: [D76825663](https://our.internmc.facebook.com/intern/diff/D76825663/)
Differential Revision: [D76825663](https://our.internmc.facebook.com/intern/diff/D76825663)
[ghstack-poisoned]
Pull Request resolved: #11758 ghstack-source-id: 290994800 Expose the API to set/get backend option. We can either pass in {backend_name, backend options} or {backend options map} Differential Revision: [D76825663](https://our.internmc.facebook.com/intern/diff/D76825663/)
|
This pull request was exported from Phabricator. Differential Revision: D76825663 |
Expose the API to set/get backend option. We can either pass in {backend_name, backend options} or {backend options map}
Differential Revision: [D76825663](https://our.internmc.facebook.com/intern/diff/D76825663/)
Differential Revision: [D76825663](https://our.internmc.facebook.com/intern/diff/D76825663)
[ghstack-poisoned]
Pull Request resolved: #11758 ghstack-source-id: 290994800 Expose the API to set/get backend option. We can either pass in {backend_name, backend options} or {backend options map} Differential Revision: [D76825663](https://our.internmc.facebook.com/intern/diff/D76825663/)
|
This pull request was exported from Phabricator. Differential Revision: D76825663 |
| * @return Error::Ok on success, Error::NotFound if backend is not found, or | ||
| * other error codes on failure | ||
| */ | ||
| Error get_option( |
There was a problem hiding this comment.
| Error get_option( | |
| Error get_options( |
| * @return Error::Ok on success, or the first error encountered when processing | ||
| * the entries | ||
| */ | ||
| Error get_option( |
There was a problem hiding this comment.
I dont think we need this. If users want something like that, they can implement it or we wait to see if users want options like that and introduce it later.
There was a problem hiding this comment.
Do you mean get_option function or the get_option with backend option map?
There was a problem hiding this comment.
with backend options map, is what i meant
Expose the API to set/get backend option. We can either pass in {backend_name, backend options} or {backend options map}
Differential Revision: [D76825663](https://our.internmc.facebook.com/intern/diff/D76825663/)
Differential Revision: [D76825663](https://our.internmc.facebook.com/intern/diff/D76825663)
[ghstack-poisoned]
Pull Request resolved: #11758 ghstack-source-id: 290994800 Expose the API to set/get backend option. We can either pass in {backend_name, backend options} or {backend options map} Differential Revision: [D76825663](https://our.internmc.facebook.com/intern/diff/D76825663/)
|
This pull request was exported from Phabricator. Differential Revision: D76825663 |
…s} only
This PR only expose the set_option/get_option API via the pair {backend_name, backend_options}, without necessarily backend options map. The backend options map and it's corresponding API will be exposed to another PR
Reference PR in #11758 which exposes the set_option/get_option with backendoptions map too
Differential Revision: [D77190316](https://our.internmc.facebook.com/intern/diff/D77190316/)
[ghstack-poisoned]
…s} only
This PR only expose the set_option/get_option API via the pair {backend_name, backend_options}, without necessarily backend options map. The backend options map and it's corresponding API will be exposed to another PR
Reference PR in #11758 which exposes the set_option/get_option with backendoptions map too
Differential Revision: [D77190316](https://our.internmc.facebook.com/intern/diff/D77190316/)
ghstack-source-id: 292211297
Pull Request resolved: #11865
…ackend_name, backend options} only"
This PR only expose the set_option/get_option API via the pair {backend_name, backend_options}, without necessarily backend options map. The backend options map and it's corresponding API will be exposed to another PR
Reference PR in #11758 which exposes the set_option/get_option with backendoptions map too
Differential Revision: [D77190316](https://our.internmc.facebook.com/intern/diff/D77190316/)
[ghstack-poisoned]
…kend options} only"
This PR only expose the set_option/get_option API via the pair {backend_name, backend_options}, without necessarily backend options map. The backend options map and it's corresponding API will be exposed to another PR
Reference PR in #11758 which exposes the set_option/get_option with backendoptions map too
Differential Revision: [D77190316](https://our.internmc.facebook.com/intern/diff/D77190316/)
[ghstack-poisoned]
…s} only Pull Request resolved: #11865 This PR only expose the set_option/get_option API via the pair {backend_name, backend_options}, without necessarily backend options map. The backend options map and it's corresponding API will be exposed to another PR Reference PR in #11758 which exposes the set_option/get_option with backendoptions map too ghstack-source-id: 292211297 Differential Revision: [D77190316](https://our.internmc.facebook.com/intern/diff/D77190316/)
…ackend_name, backend options} only"
This PR only expose the set_option/get_option API via the pair {backend_name, backend_options}, without necessarily backend options map. The backend options map and it's corresponding API will be exposed to another PR
Reference PR in #11758 which exposes the set_option/get_option with backendoptions map too
Differential Revision: [D77190316](https://our.internmc.facebook.com/intern/diff/D77190316/)
[ghstack-poisoned]
…kend options} only"
This PR only expose the set_option/get_option API via the pair {backend_name, backend_options}, without necessarily backend options map. The backend options map and it's corresponding API will be exposed to another PR
Reference PR in #11758 which exposes the set_option/get_option with backendoptions map too
Differential Revision: [D77190316](https://our.internmc.facebook.com/intern/diff/D77190316/)
[ghstack-poisoned]
…s} only Pull Request resolved: #11865 This PR only expose the set_option/get_option API via the pair {backend_name, backend_options}, without necessarily backend options map. The backend options map and it's corresponding API will be exposed to another PR Reference PR in #11758 which exposes the set_option/get_option with backendoptions map too ghstack-source-id: 292211297 Differential Revision: [D77190316](https://our.internmc.facebook.com/intern/diff/D77190316/)
…ackend_name, backend options} only"
This PR only expose the set_option/get_option API via the pair {backend_name, backend_options}, without necessarily backend options map. The backend options map and it's corresponding API will be exposed to another PR
Reference PR in #11758 which exposes the set_option/get_option with backendoptions map too
Differential Revision: [D77190316](https://our.internmc.facebook.com/intern/diff/D77190316/)
[ghstack-poisoned]
…kend options} only"
This PR only expose the set_option/get_option API via the pair {backend_name, backend_options}, without necessarily backend options map. The backend options map and it's corresponding API will be exposed to another PR
Reference PR in #11758 which exposes the set_option/get_option with backendoptions map too
Differential Revision: [D77190316](https://our.internmc.facebook.com/intern/diff/D77190316/)
[ghstack-poisoned]
…s} only Pull Request resolved: #11865 This PR only expose the set_option/get_option API via the pair {backend_name, backend_options}, without necessarily backend options map. The backend options map and it's corresponding API will be exposed to another PR Reference PR in #11758 which exposes the set_option/get_option with backendoptions map too ghstack-source-id: 292211297 Differential Revision: [D77190316](https://our.internmc.facebook.com/intern/diff/D77190316/)
…ackend_name, backend options} only"
This PR only expose the set_option/get_option API via the pair {backend_name, backend_options}, without necessarily backend options map. The backend options map and it's corresponding API will be exposed to another PR
Reference PR in #11758 which exposes the set_option/get_option with backendoptions map too
Differential Revision: [D77190316](https://our.internmc.facebook.com/intern/diff/D77190316/)
[ghstack-poisoned]
…kend options} only"
This PR only expose the set_option/get_option API via the pair {backend_name, backend_options}, without necessarily backend options map. The backend options map and it's corresponding API will be exposed to another PR
Reference PR in #11758 which exposes the set_option/get_option with backendoptions map too
Differential Revision: [D77190316](https://our.internmc.facebook.com/intern/diff/D77190316/)
[ghstack-poisoned]
…s} only Pull Request resolved: #11865 This PR only expose the set_option/get_option API via the pair {backend_name, backend_options}, without necessarily backend options map. The backend options map and it's corresponding API will be exposed to another PR Reference PR in #11758 which exposes the set_option/get_option with backendoptions map too ghstack-source-id: 292250319 Differential Revision: [D77190316](https://our.internmc.facebook.com/intern/diff/D77190316/)
…ackend_name, backend options} only"
This PR only expose the set_option/get_option API via the pair {backend_name, backend_options}, without necessarily backend options map. The backend options map and it's corresponding API will be exposed to another PR
Reference PR in #11758 which exposes the set_option/get_option with backendoptions map too
Differential Revision: [D77190316](https://our.internmc.facebook.com/intern/diff/D77190316/)
[ghstack-poisoned]
…kend options} only"
This PR only expose the set_option/get_option API via the pair {backend_name, backend_options}, without necessarily backend options map. The backend options map and it's corresponding API will be exposed to another PR
Reference PR in #11758 which exposes the set_option/get_option with backendoptions map too
Differential Revision: [D77190316](https://our.internmc.facebook.com/intern/diff/D77190316/)
[ghstack-poisoned]
…s} only Pull Request resolved: #11865 This PR only expose the set_option/get_option API via the pair {backend_name, backend_options}, without necessarily backend options map. The backend options map and it's corresponding API will be exposed to another PR Reference PR in #11758 which exposes the set_option/get_option with backendoptions map too ghstack-source-id: 292255640 Differential Revision: [D77190316](https://our.internmc.facebook.com/intern/diff/D77190316/)
…ackend_name, backend options} only"
This PR only expose the set_option/get_option API via the pair {backend_name, backend_options}, without necessarily backend options map. The backend options map and it's corresponding API will be exposed to another PR
Reference PR in #11758 which exposes the set_option/get_option with backendoptions map too
Differential Revision: [D77190316](https://our.internmc.facebook.com/intern/diff/D77190316/)
[ghstack-poisoned]
…kend options} only"
This PR only expose the set_option/get_option API via the pair {backend_name, backend_options}, without necessarily backend options map. The backend options map and it's corresponding API will be exposed to another PR
Reference PR in #11758 which exposes the set_option/get_option with backendoptions map too
Differential Revision: [D77190316](https://our.internmc.facebook.com/intern/diff/D77190316/)
[ghstack-poisoned]
…s} only Pull Request resolved: #11865 This PR only expose the set_option/get_option API via the pair {backend_name, backend_options}, without necessarily backend options map. The backend options map and it's corresponding API will be exposed to another PR Reference PR in #11758 which exposes the set_option/get_option with backendoptions map too ghstack-source-id: 292257887 Differential Revision: [D77190316](https://our.internmc.facebook.com/intern/diff/D77190316/)
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
2 similar comments
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
|
Hi @cccclai! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Stack from ghstack (oldest at bottom):
Expose the API to set/get backend option. We can either pass in {backend_name, backend options} or {backend options map}
Differential Revision: D76825663
Differential Revision: D76825663