-
Notifications
You must be signed in to change notification settings - Fork 960
Use caching allocator for runner (#15730) #15730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kimishpatel
wants to merge
58
commits into
main
Choose a base branch
from
gh/kimishpatel/213/head
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+25
−4
Open
Changes from all commits
Commits
Show all changes
58 commits
Select commit
Hold shift + click to select a range
3f789b8
[Executorch] parallelize op_choose_qparams
kimishpatel 08dd980
[Executorch] Add simd path for op quantize
kimishpatel 27fc8b1
[Executorch] Add multithreading for op_quantize
kimishpatel ae61ab4
Reduce allocation overhead in quantized sdpa
kimishpatel ea16e15
[Executorch] Introduce caching cpu memory allocator
kimishpatel c3ed4b2
Update base for Update on "[Executorch] Introduce caching cpu memory …
kimishpatel 08ab552
Update on "[Executorch] Introduce caching cpu memory allocator"
kimishpatel dbf63cc
Update base for Update on "[Executorch] Introduce caching cpu memory …
kimishpatel f9ce984
Update on "[Executorch] Introduce caching cpu memory allocator"
kimishpatel 86c7c4b
Update base for Update on "[Executorch] Introduce caching cpu memory …
kimishpatel 0c23c32
Update on "[Executorch] Introduce caching cpu memory allocator"
kimishpatel 68d76d3
Update base for Update on "[Executorch] Introduce caching cpu memory …
kimishpatel 79bb135
Update on "[Executorch] Introduce caching cpu memory allocator"
kimishpatel 351a400
[Executorch] Use temp allocator for allocating scratch memory
kimishpatel b4fdc22
[Executorch] Make module constructors uniform across
kimishpatel daca5e0
Update base for Update on "[Executorch][LLM] Use caching allocator fo…
kimishpatel 30c6fba
Update base for Update on "[Executorch][LLM] Use caching allocator fo…
kimishpatel e73b365
Update base for Update on "[Executorch][LLM] Use caching allocator fo…
kimishpatel f12869c
Update base for Update on "[Executorch][LLM] Use caching allocator fo…
kimishpatel 7f9288a
Update base for Update on "[Executorch][LLM] Use caching allocator fo…
kimishpatel 3efee70
Update base for Update on "[Executorch][LLM] Use caching allocator fo…
kimishpatel 75900d0
Update base for Update on "[Executorch][LLM] Use caching allocator fo…
kimishpatel ca1757a
Update base for Update on "[Executorch][LLM] Use caching allocator fo…
kimishpatel a4912c5
Update base for Update on "[Executorch][LLM] Use caching allocator fo…
kimishpatel 39cd25d
Update base for Update on "[Executorch][LLM] Use caching allocator fo…
kimishpatel 5bce956
Update base for Update on "[Executorch][LLM] Use caching allocator fo…
kimishpatel 5df2408
Update base for Update on "[Executorch][LLM] Use caching allocator fo…
kimishpatel 6a0d471
Update base for Update on "[Executorch][LLM] Use caching allocator fo…
kimishpatel 0bf3b2e
Update base for Update on "[Executorch][LLM] Use caching allocator fo…
kimishpatel d83b4a9
Update base for Update on "[Executorch][LLM] Use caching allocator fo…
kimishpatel a1f687f
Update base for Update on "[Executorch][LLM] Use caching allocator fo…
kimishpatel 2d79945
Update base for Update on "[Executorch][LLM] Use caching allocator fo…
kimishpatel 365be54
Update base for Update on "[Executorch][LLM] Use caching allocator fo…
kimishpatel ba27007
Update base for Update on "[Executorch][LLM] Use caching allocator fo…
kimishpatel 20854fc
Update base for Update on "[Executorch][LLM] Use caching allocator fo…
kimishpatel 36cce27
Update base for Update on "[Executorch][LLM] Use caching allocator fo…
kimishpatel 834171f
Update base for Update on "[Executorch][LLM] Use caching allocator fo…
kimishpatel bae4829
Update base for Update on "[Executorch][LLM] Use caching allocator fo…
kimishpatel 71cc532
Update base for Update on "[Executorch][LLM] Use caching allocator fo…
kimishpatel 230cd24
Update base for Update on "[Executorch][LLM] Use caching allocator fo…
kimishpatel 997b5e2
Update base for Update on "[Executorch][LLM] Use caching allocator fo…
kimishpatel 7590e9c
Update base for Update on "[Executorch][LLM] Use caching allocator fo…
kimishpatel f06f5ba
Update base for Update on "[Executorch][LLM] Use caching allocator fo…
kimishpatel e22cb35
Update base for Update on "[Executorch][LLM] Use caching allocator fo…
kimishpatel 251b270
Update base for Update on "[Executorch][LLM] Use caching allocator fo…
kimishpatel 6ebb435
Use caching allocator for runner (#15730)
kimishpatel d759f09
Update base for Update on "Use caching allocator for runner (#15730)"
kimishpatel 11ec89c
Update on "Use caching allocator for runner (#15730)"
kimishpatel e30bae0
Update base for Update on "Use caching allocator for runner (#15730)"
kimishpatel 704fb2e
Update on "Use caching allocator for runner (#15730)"
kimishpatel 467774d
Update base for Update on "Use caching allocator for runner (#15730)"
kimishpatel 7359cf2
Update on "Use caching allocator for runner (#15730)"
kimishpatel d8b32c6
Update base for Update on "Use caching allocator for runner (#15730)"
kimishpatel 5b9bf5e
Update on "Use caching allocator for runner (#15730)"
kimishpatel 42830ac
Update base for Update on "Use caching allocator for runner (#15730)"
kimishpatel 3dd3158
Update on "Use caching allocator for runner (#15730)"
kimishpatel 056a2a3
Update base for Update on "Use caching allocator for runner (#15730)"
kimishpatel c75df37
Update on "Use caching allocator for runner (#15730)"
kimishpatel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The hardcoded value of 10MB for the caching allocator size should be documented or made configurable. According to the PR description, this improves performance by 6% on iOS for SDPA op temp allocations, but different models or use cases may benefit from different cache sizes. Consider: