Add C++ unit tests for cadence::quantized_conv2d_nhwc + add depthwise_nhwc operator + tests#18479
Merged
meta-codesync[bot] merged 1 commit intopytorch:mainfrom Apr 25, 2026
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18479
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 Cancelled Job, 2 Unrelated FailuresAs of commit d5c324b with merge base de8ce55 ( CANCELLED JOB - The following job was cancelled. Please retry:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
@hsharma35 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D96507563. |
meta-cla
Bot
added
the
CLA Signed
This PR needs a
|
meta-codesync
Bot
changed the title
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Mar 24, 2026
Summary: Add test_op_quantized_conv2d_nhwc.cpp covering 17 test combinations from the Python test_quantized_conv2d_nhwc_out. Tests cover Conv2d (4D NHWC) and Conv1d (3D NLC) variants including basic, stride, padding, and depthwise cases, using kernel registry dispatch. Reviewed By: RahulC7 Differential Revision: D96507563
hsharma35
force-pushed
the
export-D96507563
branch
from
41f1e95 to
5df658a
Compare
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Mar 25, 2026
Summary: Pull Request resolved: pytorch#18479 Add test_op_quantized_conv2d_nhwc.cpp covering 17 test combinations from the Python test_quantized_conv2d_nhwc_out. Tests cover Conv2d (4D NHWC) and Conv1d (3D NLC) variants including basic, stride, padding, and depthwise cases, using kernel registry dispatch. Reviewed By: RahulC7 Differential Revision: D96507563
hsharma35
force-pushed
the
export-D96507563
branch
2 times, most recently
from
70b6bd6 to
7f776c6
Compare
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Mar 25, 2026
Summary: Add test_op_quantized_conv2d_nhwc.cpp covering 17 test combinations from the Python test_quantized_conv2d_nhwc_out. Tests cover Conv2d (4D NHWC) and Conv1d (3D NLC) variants including basic, stride, padding, and depthwise cases, using kernel registry dispatch. Reviewed By: RahulC7 Differential Revision: D96507563
RahulC7
approved these changes
Mar 25, 2026
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Mar 25, 2026
Summary: Add test_op_quantized_conv2d_nhwc.cpp covering 17 test combinations from the Python test_quantized_conv2d_nhwc_out. Tests cover Conv2d (4D NHWC) and Conv1d (3D NLC) variants including basic, stride, padding, and depthwise cases, using kernel registry dispatch. Reviewed By: RahulC7 Differential Revision: D96507563
hsharma35
force-pushed
the
export-D96507563
branch
from
7f776c6 to
c1772a4
Compare
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Mar 25, 2026
Summary: Add test_op_quantized_conv2d_nhwc.cpp covering 17 test combinations from the Python test_quantized_conv2d_nhwc_out. Tests cover Conv2d (4D NHWC) and Conv1d (3D NLC) variants including basic, stride, padding, and depthwise cases, using kernel registry dispatch. Reviewed By: RahulC7 Differential Revision: D96507563
hsharma35
force-pushed
the
export-D96507563
branch
from
c1772a4 to
53149ed
Compare
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Mar 25, 2026
Summary: Pull Request resolved: pytorch#18479 Add test_op_quantized_conv2d_nhwc.cpp covering 17 test combinations from the Python test_quantized_conv2d_nhwc_out. Tests cover Conv2d (4D NHWC) and Conv1d (3D NLC) variants including basic, stride, padding, and depthwise cases, using kernel registry dispatch. Reviewed By: RahulC7 Differential Revision: D96507563
hsharma35
force-pushed
the
export-D96507563
branch
from
53149ed to
8aa162e
Compare
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Mar 25, 2026
Summary: Pull Request resolved: pytorch#18479 Add test_op_quantized_conv2d_nhwc.cpp covering 17 test combinations from the Python test_quantized_conv2d_nhwc_out. Tests cover Conv2d (4D NHWC) and Conv1d (3D NLC) variants including basic, stride, padding, and depthwise cases, using kernel registry dispatch. Reviewed By: RahulC7 Differential Revision: D96507563
hsharma35
force-pushed
the
export-D96507563
branch
from
8aa162e to
e280f97
Compare
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Mar 25, 2026
Summary: Pull Request resolved: pytorch#18479 Add test_op_quantized_conv2d_nhwc.cpp covering 17 test combinations from the Python test_quantized_conv2d_nhwc_out. Tests cover Conv2d (4D NHWC) and Conv1d (3D NLC) variants including basic, stride, padding, and depthwise cases, using kernel registry dispatch. Reviewed By: RahulC7 Differential Revision: D96507563
hsharma35
force-pushed
the
export-D96507563
branch
from
e280f97 to
7b6e022
Compare
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Mar 26, 2026
Summary: Add test_op_quantized_conv2d_nhwc.cpp covering 17 test combinations from the Python test_quantized_conv2d_nhwc_out. Tests cover Conv2d (4D NHWC) and Conv1d (3D NLC) variants including basic, stride, padding, and depthwise cases, using kernel registry dispatch. Reviewed By: RahulC7 Differential Revision: D96507563
hsharma35
force-pushed
the
export-D96507563
branch
from
7b6e022 to
6b110b0
Compare
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Mar 26, 2026
Summary: Pull Request resolved: pytorch#18479 Add test_op_quantized_conv2d_nhwc.cpp covering 17 test combinations from the Python test_quantized_conv2d_nhwc_out. Tests cover Conv2d (4D NHWC) and Conv1d (3D NLC) variants including basic, stride, padding, and depthwise cases, using kernel registry dispatch. Reviewed By: RahulC7 Differential Revision: D96507563
hsharma35
force-pushed
the
export-D96507563
branch
from
6b110b0 to
80b3f22
Compare
…_nhwc operator + tests Summary: Add C++ unit tests for cadence::quantized_conv2d_nhwc.out using the kernel registry dispatch pattern, plus introduce the cadence::quantized_conv2d_depthwise_nhwc.out operator (registration in custom_ops.yaml + arg-validation in check_op_args.h) and its corresponding C++ test. The depthwise variant is added in the same diff because the channels-last NHWC test infrastructure is shared between the two and pulling them apart would require duplicating significant kernel-dispatch boilerplate. Both ops use BoxedEvalueList<int64_t> for IntArrayRef params (stride, padding, dilation). Part of the Python -> C++ operator test migration tracked in the jarvis-operator-testing box. Reviewed By: zonglinpeng, RahulC7 Differential Revision: D96507563
meta-codesync
Bot
changed the title
hsharma35
force-pushed
the
export-D96507563
branch
from
80b3f22 to
d5c324b
Compare
mcremon-meta
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Add C++ unit tests for cadence::quantized_conv2d_nhwc.out using the kernel registry dispatch pattern, plus introduce the cadence::quantized_conv2d_depthwise_nhwc.out operator (registration in custom_ops.yaml + arg-validation in check_op_args.h) and its corresponding C++ test. The depthwise variant is added in the same diff because the channels-last NHWC test infrastructure is shared between the two and pulling them apart would require duplicating significant kernel-dispatch boilerplate. Both ops use BoxedEvalueList<int64_t> for IntArrayRef params (stride, padding, dilation). Part of the Python -> C++ operator test migration tracked in the jarvis-operator-testing box.
Reviewed By: zonglinpeng, RahulC7
Differential Revision: D96507563