NXP backend: Add QuantizeFusedConvBnBiasAtenPass call to integration tests pipeline#18904
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18904
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 Cancelled Jobs, 2 Unrelated FailuresAs of commit 79f409c with merge base 8a97ac7 ( CANCELLED JOBS - The following jobs were cancelled. Please retry:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Pull request overview
Adds an ATen-graph transform into the NXP integration-test quantization flow to better support QAT graphs that include biasless convolutions (by ensuring fused/introduced conv biases are quantized/dequantized appropriately before lowering).
Changes:
- Import
QuantizeFusedConvBnBiasAtenPassinto the NXP integration-test utilities. - Invoke
QuantizeFusedConvBnBiasAtenPass(default_zero_bias=True)afterconvert_pt2e(...)whenuse_qatis enabled.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
f490656 to
bf1c119
Compare
bf1c119 to
7b05fe1
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
7b05fe1 to
c5f0a07
Compare
JakeStevens
left a comment
There was a problem hiding this comment.
seems nxp tests are failing with incorrect number of nodes.
Doe sthis change reduce number of q/dq since activation and batch norm are observed togetehr with conv if fusable?
|
I will look at this in a sec. I was primarily trying to resolve our internal tests hanging on this PR. Edit: The tests expected bias to be introduced in biasless convolutions. This changed for PTQ after I introduced the conditioning of |
c5f0a07 to
7e596ce
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
7e596ce to
9763824
Compare
9763824 to
f500905
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
f500905 to
79f409c
Compare
Adds call to
QuantizeFusedConvBnBiasAtenPassin conversion pipeline for integration tests. The pass enables QAT support for models containing biasless convolutions in integration tests.Test plan
Covered by NXP internal tests.
cc @robert-kalmar @JakeStevens @digantdesai