Skip to content

Ethos Driver Backwards Compatibility (#19116)#19116

Merged
meta-codesync[bot] merged 1 commit intopytorch:mainfrom
gkrulce:export-D102359186
Apr 30, 2026
Merged

Ethos Driver Backwards Compatibility (#19116)#19116
meta-codesync[bot] merged 1 commit intopytorch:mainfrom
gkrulce:export-D102359186

Conversation

@gkrulce
Copy link
Copy Markdown
Contributor

@gkrulce gkrulce commented Apr 24, 2026

Summary:

The version of ethos driver that supports multiple devices / multiple
NPUs has a few breaking API changes. Installing backwards compatibility hooks
so that Executorch continues to work with both old and new driver code.

It adds the new APIs as weak definitions and redirects to old driver code. If
new driver code is available, those definitions override the weak definitions.

Driver code ref:
https://gitlab.arm.com/artificial-intelligence/ethos-u/ethos-u-core-driver/-/blob/experimental/multidevice/README.md?ref_type=heads#experimental---multi-device

Reviewed By: digantdesai

Differential Revision: D102359186

@gkrulce gkrulce requested a review from digantdesai as a code owner April 24, 2026 17:17
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Apr 24, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19116

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 4 New Failures, 4 Unrelated Failures

As of commit a92a6b8 with merge base e4ab34d (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 24, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented Apr 24, 2026

@gkrulce has exported this pull request. If you are a Meta employee, you can view the originating Diff in D102359186.

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Apr 24, 2026

Workflows were awaiting approval. CI has now been triggered for the ciflow labels on this PR.

@github-actions
Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@gkrulce gkrulce force-pushed the export-D102359186 branch 2 times, most recently from 39f2210 to 688adc7 Compare April 24, 2026 17:41
@3l1 3l1 self-requested a review April 25, 2026 00:07
@gkrulce gkrulce force-pushed the export-D102359186 branch from 688adc7 to 431301a Compare April 25, 2026 00:30
@meta-codesync meta-codesync Bot changed the title Ethos Driver Backwards Compatibility Ethos Driver Backwards Compatibility (#19116) Apr 25, 2026
@gkrulce gkrulce force-pushed the export-D102359186 branch from 431301a to 140366d Compare April 25, 2026 17:01
gkrulce added a commit to gkrulce/executorch that referenced this pull request Apr 25, 2026
Summary:

The version of ethos driver that supports multiple devices / multiple
NPUs has a few breaking API changes. Installing backwards compatibility hooks
so that Executorch continues to work with both old and new driver code.

It adds the new APIs as weak definitions and redirects to old driver code. If
new driver code is available, those definitions override the weak definitions.

Driver code ref:
https://gitlab.arm.com/artificial-intelligence/ethos-u/ethos-u-core-driver/-/blob/experimental/multidevice/README.md?ref_type=heads#experimental---multi-device

Differential Revision: D102359186
@gkrulce gkrulce force-pushed the export-D102359186 branch from 140366d to bd51c1c Compare April 27, 2026 15:45
gkrulce added a commit to gkrulce/executorch that referenced this pull request Apr 27, 2026
Summary:

The version of ethos driver that supports multiple devices / multiple
NPUs has a few breaking API changes. Installing backwards compatibility hooks
so that Executorch continues to work with both old and new driver code.

It adds the new APIs as weak definitions and redirects to old driver code. If
new driver code is available, those definitions override the weak definitions.

Driver code ref:
https://gitlab.arm.com/artificial-intelligence/ethos-u/ethos-u-core-driver/-/blob/experimental/multidevice/README.md?ref_type=heads#experimental---multi-device

Differential Revision: D102359186
@gkrulce gkrulce force-pushed the export-D102359186 branch from 79c360f to 9983423 Compare April 28, 2026 15:28
gkrulce added a commit to gkrulce/executorch that referenced this pull request Apr 28, 2026
Summary:

The version of ethos driver that supports multiple devices / multiple
NPUs has a few breaking API changes. Installing backwards compatibility hooks
so that Executorch continues to work with both old and new driver code.

It adds the new APIs as weak definitions and redirects to old driver code. If
new driver code is available, those definitions override the weak definitions.

Driver code ref:
https://gitlab.arm.com/artificial-intelligence/ethos-u/ethos-u-core-driver/-/blob/experimental/multidevice/README.md?ref_type=heads#experimental---multi-device

Differential Revision: D102359186
@meta-codesync meta-codesync Bot changed the title Ethos Driver Backwards Compatibility (#19116) Ethos Driver Backwards Compatibility Apr 29, 2026
@gkrulce gkrulce force-pushed the export-D102359186 branch from 9983423 to 648e165 Compare April 29, 2026 17:56
Copy link
Copy Markdown
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@digantdesai
Copy link
Copy Markdown
Contributor

cc: @zingo as FYI, should be harmless.

Summary:

The version of ethos driver that supports multiple devices / multiple
NPUs has a few breaking API changes. Installing backwards compatibility hooks
so that Executorch continues to work with both old and new driver code.

It adds the new APIs as weak definitions and redirects to old driver code. If
new driver code is available, those definitions override the weak definitions.

Driver code ref:
https://gitlab.arm.com/artificial-intelligence/ethos-u/ethos-u-core-driver/-/blob/experimental/multidevice/README.md?ref_type=heads#experimental---multi-device

Reviewed By: digantdesai

Differential Revision: D102359186
@meta-codesync meta-codesync Bot changed the title Ethos Driver Backwards Compatibility Ethos Driver Backwards Compatibility (#19116) Apr 29, 2026
gkrulce added a commit to gkrulce/executorch that referenced this pull request Apr 29, 2026
Summary:

The version of ethos driver that supports multiple devices / multiple
NPUs has a few breaking API changes. Installing backwards compatibility hooks
so that Executorch continues to work with both old and new driver code.

It adds the new APIs as weak definitions and redirects to old driver code. If
new driver code is available, those definitions override the weak definitions.

Driver code ref:
https://gitlab.arm.com/artificial-intelligence/ethos-u/ethos-u-core-driver/-/blob/experimental/multidevice/README.md?ref_type=heads#experimental---multi-device

Reviewed By: digantdesai

Differential Revision: D102359186
@gkrulce gkrulce force-pushed the export-D102359186 branch 2 times, most recently from 2ae1139 to a92a6b8 Compare April 29, 2026 19:09
@meta-codesync meta-codesync Bot merged commit e4ede92 into pytorch:main Apr 30, 2026
431 of 443 checks passed
@perheld
Copy link
Copy Markdown
Collaborator

perheld commented Apr 30, 2026

cc: @zingo as FYI, should be harmless.

FYI. Funny thing, it broke our internal cppcheck test. So that highlights the need for cppcheck to make it into lintrunner-adapters so it can run upstream as well. WIP: justinchuby/lintrunner-adapters#137 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported module: arm Issues related to arm backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants