Ethos Driver Backwards Compatibility (#19116)#19116
Ethos Driver Backwards Compatibility (#19116)#19116meta-codesync[bot] merged 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19116
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 4 New Failures, 4 Unrelated FailuresAs of commit a92a6b8 with merge base e4ab34d ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@gkrulce has exported this pull request. If you are a Meta employee, you can view the originating Diff in D102359186. |
|
|
This PR needs a
|
39f2210 to
688adc7
Compare
688adc7 to
431301a
Compare
431301a to
140366d
Compare
Summary: The version of ethos driver that supports multiple devices / multiple NPUs has a few breaking API changes. Installing backwards compatibility hooks so that Executorch continues to work with both old and new driver code. It adds the new APIs as weak definitions and redirects to old driver code. If new driver code is available, those definitions override the weak definitions. Driver code ref: https://gitlab.arm.com/artificial-intelligence/ethos-u/ethos-u-core-driver/-/blob/experimental/multidevice/README.md?ref_type=heads#experimental---multi-device Differential Revision: D102359186
140366d to
bd51c1c
Compare
Summary: The version of ethos driver that supports multiple devices / multiple NPUs has a few breaking API changes. Installing backwards compatibility hooks so that Executorch continues to work with both old and new driver code. It adds the new APIs as weak definitions and redirects to old driver code. If new driver code is available, those definitions override the weak definitions. Driver code ref: https://gitlab.arm.com/artificial-intelligence/ethos-u/ethos-u-core-driver/-/blob/experimental/multidevice/README.md?ref_type=heads#experimental---multi-device Differential Revision: D102359186
79c360f to
9983423
Compare
Summary: The version of ethos driver that supports multiple devices / multiple NPUs has a few breaking API changes. Installing backwards compatibility hooks so that Executorch continues to work with both old and new driver code. It adds the new APIs as weak definitions and redirects to old driver code. If new driver code is available, those definitions override the weak definitions. Driver code ref: https://gitlab.arm.com/artificial-intelligence/ethos-u/ethos-u-core-driver/-/blob/experimental/multidevice/README.md?ref_type=heads#experimental---multi-device Differential Revision: D102359186
9983423 to
648e165
Compare
digantdesai
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
|
cc: @zingo as FYI, should be harmless. |
Summary: The version of ethos driver that supports multiple devices / multiple NPUs has a few breaking API changes. Installing backwards compatibility hooks so that Executorch continues to work with both old and new driver code. It adds the new APIs as weak definitions and redirects to old driver code. If new driver code is available, those definitions override the weak definitions. Driver code ref: https://gitlab.arm.com/artificial-intelligence/ethos-u/ethos-u-core-driver/-/blob/experimental/multidevice/README.md?ref_type=heads#experimental---multi-device Reviewed By: digantdesai Differential Revision: D102359186
Summary: The version of ethos driver that supports multiple devices / multiple NPUs has a few breaking API changes. Installing backwards compatibility hooks so that Executorch continues to work with both old and new driver code. It adds the new APIs as weak definitions and redirects to old driver code. If new driver code is available, those definitions override the weak definitions. Driver code ref: https://gitlab.arm.com/artificial-intelligence/ethos-u/ethos-u-core-driver/-/blob/experimental/multidevice/README.md?ref_type=heads#experimental---multi-device Reviewed By: digantdesai Differential Revision: D102359186
2ae1139 to
a92a6b8
Compare
FYI. Funny thing, it broke our internal cppcheck test. So that highlights the need for cppcheck to make it into lintrunner-adapters so it can run upstream as well. WIP: justinchuby/lintrunner-adapters#137 :) |
Summary:
The version of ethos driver that supports multiple devices / multiple
NPUs has a few breaking API changes. Installing backwards compatibility hooks
so that Executorch continues to work with both old and new driver code.
It adds the new APIs as weak definitions and redirects to old driver code. If
new driver code is available, those definitions override the weak definitions.
Driver code ref:
https://gitlab.arm.com/artificial-intelligence/ethos-u/ethos-u-core-driver/-/blob/experimental/multidevice/README.md?ref_type=heads#experimental---multi-device
Reviewed By: digantdesai
Differential Revision: D102359186