Skip to content

Numel and Nbytes Validation (#19121)#19121

Merged
JacobSzwejbka merged 1 commit intopytorch:mainfrom
JacobSzwejbka:export-D98148157
Apr 24, 2026
Merged

Numel and Nbytes Validation (#19121)#19121
JacobSzwejbka merged 1 commit intopytorch:mainfrom
JacobSzwejbka:export-D98148157

Conversation

@JacobSzwejbka
Copy link
Copy Markdown
Contributor

@JacobSzwejbka JacobSzwejbka commented Apr 24, 2026

Summary:

Attempt 3 to check numel and nbytes overflow. This time we defer checking dynamic sized inputs until their size is realized.

Reviewed By: lucylq

Differential Revision: D98148157

@JacobSzwejbka JacobSzwejbka requested a review from lucylq as a code owner April 24, 2026 20:32
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Apr 24, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19121

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

⏳ 33 Pending, 1 Unrelated Failure

As of commit fc580c8 with merge base cb94506 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 24, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented Apr 24, 2026

@JacobSzwejbka has exported this pull request. If you are a Meta employee, you can view the originating Diff in D98148157.

@github-actions
Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Summary:

Attempt 3 to check numel and nbytes overflow. This time we defer checking dynamic sized inputs until their size is realized.

Reviewed By: lucylq

Differential Revision: D98148157
@meta-codesync meta-codesync Bot changed the title Numel and Nbytes Validation Numel and Nbytes Validation (#19121) Apr 24, 2026
@JacobSzwejbka JacobSzwejbka merged commit 56da964 into pytorch:main Apr 24, 2026
163 of 169 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants