Skip to content

Android: Module implements Closeable #19124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
psiddh merged 1 commit into from
Apr 25, 2026
Merged

Android: Module implements Closeable #19124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions extension/android/executorch_android/src/main/java/org/pytorch/executorch/Module.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
import com.facebook.jni.annotations.DoNotStrip;
import com.facebook.soloader.nativeloader.NativeLoader;
import com.facebook.soloader.nativeloader.SystemDelegate;
import java.io.Closeable;
import java.util.HashMap;
import java.util.Map;
import java.util.concurrent.locks.Lock;
Expand All @@ -24,7 +25,7 @@
* <p>Warning: These APIs are experimental and subject to change without notice
*/
@Experimental
public class Module {
public class Module implements Closeable {

static {
if (!NativeLoader.isInitialized()) {
Expand Down Expand Up @@ -274,12 +275,19 @@ public boolean etdump() {
public void destroy() {
if (mLock.tryLock()) {
try {
mHybridData.resetNative();
if (mHybridData.isValid()) {
mHybridData.resetNative();
}
} finally {
mLock.unlock();
}
} else {
throw new IllegalStateException("Cannot destroy module while method is executing");
}
}

@Override
public void close() {
destroy();
}
}
Loading