Skip to content

Arm backend: Suppress cppcheck false positive in Cortex-M#19274

Merged
Sebastian-Larsson merged 1 commit intopytorch:mainfrom
Sebastian-Larsson:ignore_cpp_lint
May 4, 2026
Merged

Arm backend: Suppress cppcheck false positive in Cortex-M#19274
Sebastian-Larsson merged 1 commit intopytorch:mainfrom
Sebastian-Larsson:ignore_cpp_lint

Conversation

@Sebastian-Larsson
Copy link
Copy Markdown
Collaborator

@Sebastian-Larsson Sebastian-Larsson commented May 4, 2026

Document that the local weak fallback always returns 0, while some builds replace it with a driver implementation that can return an error.

Add a targeted cppcheck suppression for the weak-symbol error check without changing runtime behavior.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @robell

Document that the local weak fallback always returns 0, while some
builds replace it with a driver implementation that can return an
error.

Add a targeted cppcheck suppression for the weak-symbol error check
without changing runtime behavior.

Change-Id: I71232d1b9670fcca35e7343db2ceccb519827969
Signed-off-by: Sebastian Larsson <sebastian.larsson@arm.com>
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 4, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19274

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 3 New Failures, 8 Cancelled Jobs, 3 Unrelated Failures

As of commit 36807f2 with merge base a6ee309 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 4, 2026
@github-actions github-actions Bot added ciflow/trunk module: arm Issues related to arm backend labels May 4, 2026
@Sebastian-Larsson Sebastian-Larsson added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate labels May 4, 2026
@Sebastian-Larsson Sebastian-Larsson merged commit 69989b7 into pytorch:main May 4, 2026
434 of 459 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: arm Issues related to arm backend partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants