Skip to content

Qualcomm AI Engine Direct - HardSigmoid follow up for FP16 / Test cases complement#2790

Closed
chuntl wants to merge 2 commits intopytorch:mainfrom
CodeLinaro:hardsigmoid_test
Closed

Qualcomm AI Engine Direct - HardSigmoid follow up for FP16 / Test cases complement#2790
chuntl wants to merge 2 commits intopytorch:mainfrom
CodeLinaro:hardsigmoid_test

Conversation

@chuntl
Copy link
Copy Markdown
Contributor

@chuntl chuntl commented Apr 1, 2024

Summary:

  • make HardSigmoid more compact in FP16
  • add online prepare utitlity test case
  • add test case for export_example.py

@chuntl
Qualcomm AI Engine Direct - HardSigmoid follow up for FP16 / Test cas…
fd88d97 
…es complement

Summary:
- make HardSigmoid more compact in FP16
- add online prepare utitlity test case
- add test case for export_example.py
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Apr 1, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2790

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 41498a5 with merge base 643c628 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 1, 2024
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Apr 1, 2024

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@chuntl
Copy link
Copy Markdown
Contributor Author

chuntl commented Apr 8, 2024

Hi @cccclai ,

Thanks for the approval, I have rebased this PR to mainline.
May I know if you could help to check it and merge this PR again, thank you!

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Apr 9, 2024

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cccclai
Copy link
Copy Markdown
Contributor

cccclai commented Apr 9, 2024

Hi @cccclai ,

Thanks for the approval, I have rebased this PR to mainline. May I know if you could help to check it and merge this PR again, thank you!

Hi sorry lost track of this pr - landing now

@cccclai
Copy link
Copy Markdown
Contributor

cccclai commented Apr 9, 2024

It seems like CI is still failing, but main should be stable, mind rebasing again?

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Apr 9, 2024

@cccclai merged this pull request in 3708e74.

@chuntl
Copy link
Copy Markdown
Contributor Author

chuntl commented Apr 9, 2024

It seems like CI is still failing, but main should be stable, mind rebasing again?

Sure, but it's merged now, may I know if I need to rebase it again?

@cccclai
Copy link
Copy Markdown
Contributor

cccclai commented Apr 9, 2024

Oh it should be good. It might due to sync issue. Thank you for making the change!

@mergennachin mergennachin mentioned this pull request Apr 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cccclai cccclai cccclai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chuntl @facebook-github-bot @cccclai