[RELEASE-ONLY CHANGES] Update release/0.2 to pin and test against PyTorch release/2.3#2818
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2818
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit 2a2df5e with merge base e5a8de0 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
84e02c5 to
8ecc530
Compare
|
|
||
| # The pip repository that hosts nightly torch packages. | ||
| TORCH_NIGHTLY_URL="https://download.pytorch.org/whl/nightly/cpu" | ||
| TORCH_URL="https://download.pytorch.org/whl/test/cpu" |
There was a problem hiding this comment.
Curious if this will be the final url to fetch torch2.3? Maybe it's where RCs are, but not for the final release?
There was a problem hiding this comment.
All the RCs are there on that link. Once it's promoted to prod, the final prod binary will come from https://download.pytorch.org/whl/cpu or PyPI
3dfbbc0 to
e4961fd
Compare
| # To make both work, recover ExecuTorch's original dependencies by rerunning | ||
| # the install_requirements.sh. | ||
| ./install_requirements.sh | ||
| pip install --force-reinstall torch==2.3.0 --index-url https://download.pytorch.org/whl/test/cpu |
There was a problem hiding this comment.
Per my investigation in T184361451, I think we should avoid using -I as in pip install bitsandbytes -I as it seems to confuse pip list
| pip install --force-reinstall torch==2.3.0 --index-url https://download.pytorch.org/whl/test/cpu | ||
|
|
||
| echo "Finished installing llava dependencies." | ||
| pip list |
There was a problem hiding this comment.
Could we have a python -c 'import torch; print(torch.__version__)' to confirm the torch version in used here? I'm curious
There was a problem hiding this comment.
Maybe python -c 'import torchvision; print(torchvision.__version__)' and python -c 'import torchaudio; print(torchaudio.__version__)' too. From what I try to reproduce locally, their versions looks correct (trying on ET main)
(executorch) [huydo@devgpu018.odn1 ~/local/github/executorch (main)]$ python -c 'import torchvision; print(torchvision.__version__)'
0.19.0.dev20240324+cpu
(executorch) [huydo@devgpu018.odn1 ~/local/github/executorch (main)]$ python -c 'import torchaudio; print(torchaudio.__version__)'
2.2.0.dev20240324+cpu
There was a problem hiding this comment.
Added the debug log and removed -I. However, I don't even see torch version = is printed hmm
There was a problem hiding this comment.
I could see it in the log though, i.e. https://github.com/pytorch/executorch/actions/runs/8542428080/job/23404038664?pr=2818#step:11:6208
There was a problem hiding this comment.
I could see it in the log though, i.e. https://github.com/pytorch/executorch/actions/runs/8542428080/job/23404038664?pr=2818#step:11:6208
Okay, now I can see the version seems correct now and the job is going further, though it fails the failure is due to memory limits. I think Martin was asking about this in a thread and there is solution for it?
e4961fd to
a210195
Compare
a90482f to
96a5ff4
Compare
a210195 to
3b7b652
Compare
|
Will deal with T184361451 later. |
3b7b652 to
ce8b379
Compare
ce8b379 to
2a2df5e
Compare
|
Updated |
|
test-demo-ios / macos-job is flaky in all branches, it's irrelevant to this PR and the issue is tracked in #2877 |
…orch release/2.3 (#2818)
release/2.3doesn't work)install_requirements.shto install prebuilt torch-2.3 and torchvision/torchaudio.